Skip to content

Better server exception logging #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dave470003 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better server exception logging #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb12d26
Better server exception logging
dave470003 Jul 30, 2019
c249a45
Remove packages.d3r.com from composer
dave470003 Jul 30, 2019
a529fcd
Get rid of irritating deprecation
dmnc Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Snowcap/Emarsys/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ public function addBlacklistEntries(array $emails = array(), array $domains = ar
* @throws ClientException
* @throws ServerException
*/
protected function send($method = 'GET', $uri, array $body = array())
protected function send(string $method, $uri, array $body = array())
Copy link
Author

@dave470003 dave470003 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out I still get email comments from this! Hiya Dom :)

{
$headers = array('Content-Type: application/json', 'X-WSSE: ' . $this->getAuthenticationSignature());
$uri = $this->baseUrl . $uri;
Expand All @@ -911,7 +911,9 @@ protected function send($method = 'GET', $uri, array $body = array())
case JSON_ERROR_DEPTH:
throw new ClientException('JSON response could not be decoded, maximum depth reached.');
default:
throw new ServerException("JSON response could not be decoded:\n" . json_last_error_msg());
$exception = new ServerException("JSON response could not be decoded:\n" . json_last_error_msg());
$exception->setResponseMessage($responseJson);
throw $exception;
}
}

Expand Down
24 changes: 23 additions & 1 deletion src/Snowcap/Emarsys/Exception/ServerException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,27 @@

class ServerException extends \Exception
{
protected $responseMessage = null;

}
/**
* Set the response message from the server
*
* @param string $message
* @author David Fox <[email protected]>
*/
public function setResponseMessage($message)
{
$this->responseMessage = $message;
}

/**
* Return the response message set on this exception
*
* @return string
* @author David Fox <[email protected]>
*/
public function getResponseMessage()
{
return $this->responseMessage;
}
}