Feature/sentinel blocking connection pool #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABND19
force-pushed
the
feature/sentinel-blocking-connection-pool
branch
5 times, most recently
from
ed788bd to
6539da1
Compare
DABND19
force-pushed
the
feature/sentinel-blocking-connection-pool
branch
2 times, most recently
from
aca1d65 to
f6168c3
Compare
DABND19
force-pushed
the
feature/sentinel-blocking-connection-pool
branch
from
f6168c3 to
9b1fbd6
Compare
Co-authored-by: Vladyslav Vildanov <[email protected]>
* Docs: Resolve 'Unexpected indentation' warnings * Docs: Resolve 'Unexpected unindent' warnings * Docs: Resolve "more than one target for cross-reference 'Redis'" warnings When Sphinx runs, `TYPE_CHECKING` is not enabled, so the differentiating sync/async `Redis` imports don't happen, and Sphinx appears to be unable to infer which class `"Redis"` should cross-reference. --------- Co-authored-by: Vladyslav Vildanov <[email protected]>
Co-authored-by: Vladyslav Vildanov <[email protected]>
…#3333) The second definition was copied over the first definition, with the following changes: * The type annotations were copied to the second definition * The mutable default arguments to the `keys` and `args` parameters were replaced with `None`, as is best-practice. Closes redis#3332 Co-authored-by: Vladyslav Vildanov <[email protected]>
Co-authored-by: Vladyslav Vildanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.