Enable smartypants by default #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most people type straight apostrophes because they're actually on peoples' keyboards[0]. We ought to be displaying fancy/curly ones where possible[1] This change enables RedCarpet's SmartyPants implementation[2] so we'll benefit from it everywhere we render blocks of markdown. [0] https://smartquotesforsmartpeople.com/ [1] https://design.tax.service.gov.uk/hmrc-content-style-guide/ [2] https://github.com/vmg/redcarpet?tab=readme-ov-file#also-now-our-pants-are-much-smarter
peteryates
force-pushed
the
enable-smartypants-by-default
branch
from
3bb0e52 to
1aafa00
Compare
avinhurry
approved these changes
Mar 6, 2025
avinhurry
added a commit
to DFE-Digital/register-early-career-teachers-public
that referenced
this pull request
Apr 10, 2025
Smart quotes have been enabled by default in: DFE-Digital/govuk-markdown#41
avinhurry
added a commit
to DFE-Digital/register-early-career-teachers-public
that referenced
this pull request
Apr 10, 2025
Smart quotes have been enabled by default in: DFE-Digital/govuk-markdown#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people type straight apostrophes because they're actually on peoples' keyboards. We ought to be displaying fancy/curly ones where possible.
This change enables RedCarpet's SmartyPants implementation so we'll benefit from it everywhere we render blocks of markdown.