Draft
Conversation
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
|
Review app deployed to https://cpd-ec2-review-1976-web.test.teacherservices.cloud |
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
peterdavidhamilton
force-pushed
the
pdh/dqt-importers-updated
branch
from
dc4477d to
964f973
Compare
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
This reverts commit 57c48ab.
peterdavidhamilton
force-pushed
the
pdh/dqt-importers-updated
branch
from
964f973 to
81cfdee
Compare
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
- lint - rename :event_type for claims/releases - remove insertion of :local_authority_code and :establishment_number now in GIAS::School - rename :legacy_id to :dqt_id
peterdavidhamilton
force-pushed
the
pdh/dqt-importers-updated
branch
from
81cfdee to
5af3b49
Compare
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
| require "csv" | ||
|
|
||
| module AppropriateBodies::Importers | ||
| class AppropriateBodyImporter |
Contributor
There was a problem hiding this comment.
This isn't really an Importer, as it doesn't write anything? The import is done exclusively by the Importer class.
This class just provides the data to be imported, as such should, it might be more intention revealing if this class was named something like AppropriateBodyData? or if we wanted to be totally explicit AppropriateBodyFilteredImportData?
| @trns_with_induction_periods = @induction_periods_grouped_by_trn.keys | ||
| @teacher_importer_rows = TeacherImporter.new(teachers_csv, @trns_with_induction_periods).rows_with_wanted_statuses | ||
|
|
||
| @active_abs = @induction_periods_grouped_by_trn.flat_map { |_trn, ips| ips.map(&:legacy_appropriate_body_id) }.uniq |
Contributor
There was a problem hiding this comment.
It looks like @active_absis @unique_legacy_appropriate_bodies?
|
|
||
| def import_ab_rows | ||
| Rails.logger.info("Active appropriate bodies: #{@active_abs.count}") | ||
| AppropriateBody.insert_all!(@ab_importer_rows.select { |r| r.dqt_id.in?(@active_abs) }.map(&:to_h)) |
Contributor
There was a problem hiding this comment.
Should we not be filtering the @ab_importer_rows in the AppropriateBodyImporter as it already has the@active_abs to filter on?
- disable importing admin users
|
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| @@ -0,0 +1,41 @@ | |||
| appropriate_body_csv = Rails.root.join("tmp/import/appropriatebody.csv") # 537 | |||
| teachers_csv = Rails.root.join("tmp/import/teachers.csv") # 1_799_170 | |||
| @@ -0,0 +1,41 @@ | |||
| appropriate_body_csv = Rails.root.join("tmp/import/appropriatebody.csv") # 537 | |||
| teachers_csv = Rails.root.join("tmp/import/teachers.csv") # 1_799_170 | |||
| induction_period_csv = Rails.root.join("tmp/import/inductionperiods.csv") # 829_189 | |||
| appropriate_body_csv = Rails.root.join("tmp/import/appropriatebody.csv") # 537 | ||
| teachers_csv = Rails.root.join("tmp/import/teachers.csv") # 1_799_170 | ||
| induction_period_csv = Rails.root.join("tmp/import/inductionperiods.csv") # 829_189 | ||
| dfe_sign_in_mapping_csv = Rails.root.join("tmp/import/dfe-sign-in-mappings.csv") # 86 |
| teachers_csv = Rails.root.join("tmp/import/teachers.csv") # 1_799_170 | ||
| induction_period_csv = Rails.root.join("tmp/import/inductionperiods.csv") # 829_189 | ||
| dfe_sign_in_mapping_csv = Rails.root.join("tmp/import/dfe-sign-in-mappings.csv") # 86 | ||
| admin_csv = Rails.root.join("tmp/import/admins.csv") # 30 |
| induction_period_csv = Rails.root.join("tmp/import/inductionperiods.csv") # 829_189 | ||
| dfe_sign_in_mapping_csv = Rails.root.join("tmp/import/dfe-sign-in-mappings.csv") # 86 | ||
| admin_csv = Rails.root.join("tmp/import/admins.csv") # 30 | ||
| cutoff_csv = Rails.root.join("tmp/import/old-abs.csv") # 433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Second round of imported data into RIAB.
Considerations:
Changes proposed in this pull request
Guidance to review
TBC