Open
Conversation
|
|
Review app deployed to https://cpd-ec2-review-2163-web.test.teacherservices.cloud |
avinhurry
approved these changes
Feb 5, 2026
Contributor
avinhurry
left a comment
avinhurry
left a comment
There was a problem hiding this comment.
Looks good.
Just realised now that we have (finance > user_manager > admin) admin feels a bit misleading. One to ponder on.
|
|
||
| it "redirects GET /admin/users with an alert" do | ||
| it "returns unauthorised for GET /admin/users with the users access error message" do | ||
| get admin_users_path |
Contributor
There was a problem hiding this comment.
Do you think it's worth adding specs to check that GET /admin/users/:id and GET /admin/users/:id/edit are protected and show the same error message too?
cpjmcquillan
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to ticket
Context
Unauthorised access messaging was inconsistent between the Finance and Users admin areas.
Changes proposed in this pull request
Guidance to review