Conversation
|
Review app deployed to https://cpd-ec2-review-2164-web.test.teacherservices.cloud |
7dde20c to
80adfef
Compare
app/components/schools/teacher_profile_summary_list_component.html.erb
Outdated
Show resolved
Hide resolved
app/models/training_period.rb
Outdated
| end | ||
| end | ||
|
|
||
| def school_training_status |
There was a problem hiding this comment.
I think we could just name this status. training is redundant as this is a TrainingPeriod. school is also not relevant because the TrainingPeriod is linked to the ect/mentor_at_school_period, so it's not varying in this instance. It's also missing a test.
There was a problem hiding this comment.
Yep that's fair. I originally went with school_training_status because we’ve got a couple of 'status' concepts floating around (participant/induction/training-period etc) and this one is specifically 'what schools should see'. Happy to rename to something like status_for_school ... we use training_status elsewhere
There was a problem hiding this comment.
OK, I understand your concern here. status_for_school doesn't really communicate the purpose of this as the naming suggests it's more to do with the view - what the school sees - but that might not be clear in the context. training_period.training_status is just a repetition, though if we can't think of anything better we can do that. I can see training_status used in the readme for example.
There was a problem hiding this comment.
Thanks for the tests. They are fine obvs.
thenapking
left a comment
There was a problem hiding this comment.
I think this is sound, and meets the ACs, but needs a little clean-up in places.
afc51d1 to
3a40196
Compare
|
thenapking
left a comment
There was a problem hiding this comment.
Great. thanks for all the updates



Ticket here
Context
This PR covers updates to the school-facing UI when an ECT’s latest training period at the school has been withdrawn or deferred by a lead provider via the API.
Previously, these states were not surfaced consistently across the ECT list and individual ECT details pages. This PR ensures withdrawn and deferred training statuses are displayed with the correct messaging, actions, and priority whilst leaving the underlying ECT at school period unchanged.
Changes proposed in this pull request
Guidance to review