Appropriate Body "Check Data" subordinate pages by craigmdavidson · Pull Request #2174 · DFE-Digital/register-early-career-teachers-public

craigmdavidson · 2026-02-06T11:38:36Z

Context

As part of the "check-data" workflow, we need to provide detail pages for the unclaimed subgroups:

Claimable inductions
Unclaimable inductions due to missing QTS
Unclaimable inductions due to being claimed by another AppropriateBody

EPIC: https://github.com.mcas.ms/DFE-Digital/register-ects-project-board/issues/3190

Check and claim an ECT Induction
Github issue: https://github.com.mcas.ms/DFE-Digital/register-ects-project-board/issues/3166

Unclaimable inductions due to missing QTS
Github issue: https://github.com.mcas.ms/DFE-Digital/register-ects-project-board/issues/3183

Unclaimable inductions due to being claimed by another AppropriateBody
Github issue: https://github.com.mcas.ms/DFE-Digital/register-ects-project-board/issues/3182

Changes proposed in this pull request

As Built

Claimable

Unclaimable (missing QTS)

Unclaimable (claimed by another Appropriate Body)

Guidance to review

As with the parent, the key underlying entity is ECTAtSchoolPeriod rather than Teacher.
We needed to change the parent dashboard page ~ UnclaimedController from index to show to better the support subordinate pages.
Since the pages are so common we have a common
In the ViewComponents we use a strategy pattern to compose the TableSectionComponent with the appropriate TableRowComponent to get the table columns we want for each subordinate.

github-actions · 2026-02-06T11:45:37Z

Review app deployed to https://cpd-ec2-review-2174-web.test.teacherservices.cloud

sonarqubecloud · 2026-02-09T11:35:12Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

app/controllers/appropriate_bodies/unclaimed/claimable_controller.rb

app/views/appropriate_bodies/unclaimed/claimable/index.html.erb

peterdavidhamilton

Can we add trailing new lines to these files. They got missed off the last PR.

peterdavidhamilton · 2026-02-17T12:31:08Z

app/components/unclaimed_index/base_table_row_component.rb

+      Teachers::Name.new(ect_at_school_period.teacher).full_name
+    end
+
+    def teacher_trn


Should we switch to delegating here too, or is that too much?

I don't know. We are modifying the names of things slightly, which we would lose with delegation.
Based on that I haven't delegated, but we could, if you think that would be clearer?

Up to you, we could accomplish it with a prefix; maybe if more delegated methods were needed.

delegate :trn, to: :ect_at_school_period, prefix: :teacher delegate :school_name, to: :ect_at_school_period

Okay. Let's do it! 😄

spec/requests/appropriate_bodies/unclaimed/no_qts_spec.rb

app/views/appropriate_bodies/unclaimed/no_qts/index.html.erb

peterdavidhamilton · 2026-02-17T12:54:04Z

spec/components/unclaimed_index/table_section_component_spec.rb

+      html = rendered.to_html
+      expect(html).to include("Postman Pat")
+      expect(html).to include("1234567")
+      expect(html).to include("Bob Builder")


👷🏼‍♂️

peterdavidhamilton · 2026-02-17T12:54:28Z

spec/components/unclaimed_index/table_section_component_spec.rb

+
+    it "renders teacher names, TRNs, school name, and induction tutor email" do
+      html = rendered.to_html
+      expect(html).to include("Postman Pat")


Fill in detail pages for unclaimed ECTs, Each page includes search by name or TRN and paginated tables with category-specific columns.

sonarqubecloud · 2026-02-17T14:55:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

peterdavidhamilton · 2026-02-17T16:57:39Z

Can we add trailing new lines to these files. They got missed off the last PR.

Looks excellent and works as advertised. If we can follow the blank line convention I'll happily approve; don't want to hold you up.

craigmdavidson · 2026-02-17T21:02:26Z

Can we add trailing new lines to these files. They got missed off the last PR.

Looks excellent and works as advertised. If we can follow the blank line convention I'll happily approve; don't want to hold you up.

Thanks @peterdavidhamilton I think I might I'm not fully understanding this?

in the repos .editorconfig the following is defined:

insert_final_newline = true
trim_trailing_whitespace = true

So this means we final character should be a oin
These files do have a trailing new line, i.e. the last character is '\n'...

when I hexdump the first new file in the PR:

tail -c 1 app/components/unclaimed_index/claimable/table_row_component.html.erb | xxd
returns 0a which is \n? The other files on main follow this pattern. What am I missing?

When that new line is missing GitHub it shows it as red.
I'm not sure what am I missing / misunderstanding?

craigmdavidson self-assigned this Feb 6, 2026

craigmdavidson marked this pull request as draft February 6, 2026 11:38

craigmdavidson changed the base branch from main to add-appropriate-body-unclaimed-ects-dashboard February 6, 2026 11:39

craigmdavidson temporarily deployed to review February 6, 2026 11:40 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 884a95f to 03af14d Compare February 6, 2026 14:36

craigmdavidson temporarily deployed to review February 6, 2026 14:38 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 03af14d to abb8f62 Compare February 6, 2026 15:06

craigmdavidson force-pushed the add-appropriate-body-unclaimed-ects-dashboard branch from df234b5 to 6d8c483 Compare February 10, 2026 09:58

Base automatically changed from add-appropriate-body-unclaimed-ects-dashboard to main February 10, 2026 10:30

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 71f49ab to 0d755b9 Compare February 10, 2026 10:42

github-code-quality bot found potential problems Feb 10, 2026

View reviewed changes

app/controllers/appropriate_bodies/unclaimed/claimable_controller.rb Fixed Show fixed Hide fixed

craigmdavidson temporarily deployed to review February 10, 2026 10:45 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 10, 2026 12:12 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 10, 2026 14:32 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 11, 2026 14:28 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 11, 2026 15:32 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 11, 2026 15:59 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 14:22 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 15:10 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 15:48 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 16:05 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 16:15 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 12, 2026 16:26 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch 4 times, most recently from 8b9bde5 to 07ff3d4 Compare February 13, 2026 10:23

craigmdavidson marked this pull request as ready for review February 13, 2026 10:30

craigmdavidson commented Feb 13, 2026

View reviewed changes

app/views/appropriate_bodies/unclaimed/claimable/index.html.erb Outdated Show resolved Hide resolved

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 44157fc to 6486066 Compare February 13, 2026 11:46

craigmdavidson temporarily deployed to review February 13, 2026 11:48 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 6486066 to a5a8bd4 Compare February 13, 2026 16:13

craigmdavidson temporarily deployed to review February 13, 2026 16:15 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 16, 2026 09:24 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from a77403d to 2358dbc Compare February 16, 2026 09:25

craigmdavidson temporarily deployed to review February 16, 2026 09:29 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 16, 2026 10:57 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 16, 2026 12:17 — with GitHub Actions Inactive

craigmdavidson temporarily deployed to review February 16, 2026 12:31 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from f37023a to df9395b Compare February 16, 2026 16:15

craigmdavidson had a problem deploying to review February 16, 2026 16:17 — with GitHub Actions Failure

craigmdavidson temporarily deployed to review February 16, 2026 16:46 — with GitHub Actions Inactive

peterdavidhamilton requested changes Feb 17, 2026

View reviewed changes

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from df9395b to 39993cf Compare February 17, 2026 14:07

craigmdavidson temporarily deployed to review February 17, 2026 14:09 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from 39993cf to dd4e024 Compare February 17, 2026 14:23

craigmdavidson temporarily deployed to review February 17, 2026 14:26 — with GitHub Actions Inactive

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from dd4e024 to ed75657 Compare February 17, 2026 14:28

craigmdavidson temporarily deployed to review February 17, 2026 14:31 — with GitHub Actions Inactive

craigmdavidson requested a review from peterdavidhamilton February 17, 2026 14:54

craigmdavidson added 2 commits February 17, 2026 14:54

Outline subordinate detail pages

3a1a4c4

Add Unclaimed ECT details

d45687b

Fill in detail pages for unclaimed ECTs, Each page includes search by name or TRN and paginated tables with category-specific columns.

craigmdavidson force-pushed the appropriate-body-unclaimed-etc-detail-pages branch from ed75657 to d45687b Compare February 17, 2026 14:54

craigmdavidson temporarily deployed to review February 17, 2026 14:56 — with GitHub Actions Inactive

peterdavidhamilton approved these changes Feb 18, 2026

View reviewed changes

Conversation

craigmdavidson commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Changes proposed in this pull request

Guidance to review

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

sonarqubecloud bot commented Feb 9, 2026

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

peterdavidhamilton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterdavidhamilton Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

craigmdavidson Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterdavidhamilton Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

craigmdavidson Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peterdavidhamilton Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

peterdavidhamilton Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 17, 2026

Quality Gate passed

Uh oh!

peterdavidhamilton commented Feb 17, 2026

Uh oh!

craigmdavidson commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

craigmdavidson commented Feb 6, 2026 •

edited

Loading

peterdavidhamilton left a comment •

edited

Loading

craigmdavidson Feb 17, 2026 •

edited

Loading