Open
Conversation
thenapking
changed the title
|
Review app deployed to https://cpd-ec2-review-2249-web.test.teacherservices.cloud |
avinhurry
approved these changes
Feb 17, 2026
Contributor
avinhurry
left a comment
avinhurry
left a comment
There was a problem hiding this comment.
Just a couple of minor lose ends/questions but looks great
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Now we have tested the mechanism for setting an induction tutor when schools login, we can remove the flag. One school, Greyfriars, is left without an induction tutor set, for testing purposes.
Changes proposed in this pull request
It turned out cleanest to update the factory to ensure that a confirmed induction tutor is assigned to each school. Since this requires creating a contract period, some tests, which use contract periods with non-standard dates fail. I have therefore added an override to the factory.
Guidance to review