Move ECT history mentor period building to a separate class#2267
Open
tonyheadford wants to merge 1 commit intomainfrom
Open
Move ECT history mentor period building to a separate class#2267tonyheadford wants to merge 1 commit intomainfrom
tonyheadford wants to merge 1 commit intomainfrom
Conversation
tonyheadford
requested review from
ltello and
peteryates
and removed request for
peteryates
|
|
Review app deployed to https://cpd-ec2-review-2267-web.test.teacherservices.cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
To avoid confusion, move the methods that build
ECF1TeacherHistory::MentorAtSchoolPeriodfor an ECT's history out of theECF1TeacherHistoryclass.Changes proposed in this pull request
Move the functionality that adds the mentor school periods to an ECTs history to a new class
Guidance to review