Merged
Conversation
|
Review app deployed to https://cpd-ec2-review-2269-web.test.teacherservices.cloud |
avinhurry
reviewed
Feb 17, 2026
app/migration/teacher_history_converter/cleaner/fix_first_start_date.rb
Outdated
Show resolved
Hide resolved
This prewash cleaner step updates a particpant's first induction record start date to the earliest value between: * the start_date * the (date of the) created_at timestamp
Now instead of testing the cleaning is actually cleaning, just make sure we're running each of the steps.
peteryates
force-pushed
the
add-start-date-fixing-prewash-step
branch
from
0c2691c to
6bd5027
Compare
|
tonyheadford
approved these changes
Feb 18, 2026
|
Review app for PR 2269 was deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This prewash cleaner step updates a particpant's first induction record start date to the earliest value between the
start_dateand the (date of the)created_attimestamp.Fixes DFE-Digital/register-ects-project-board#3210