[WIP][3282] Add banded payment calculator outputs service#2271
Draft
leandroalemao wants to merge 1 commit intomainfrom
Draft
[WIP][3282] Add banded payment calculator outputs service#2271leandroalemao wants to merge 1 commit intomainfrom
leandroalemao wants to merge 1 commit intomainfrom
Conversation
|
|
Review app deployed to https://cpd-ec2-review-2271-web.test.teacherservices.cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
[WIP] This depends on 3278. I could stub the missing service
DeclarationTypeOutputbut we're not doing this inFlatRate::Outputsservice specs so just waiting till we make changes for it.Ticket: 3282
The
Outputsservice is going to replicate the ECF1OutputCalculatorbut with a more structured interface (rather than just exposing a method to a hash of banding values).Changes proposed in this pull request
PaymentCalculator::Banded::OutputsserviceGuidance to review
Review app