Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
Review app deployed to https://cpd-ec2-review-2274-web.test.teacherservices.cloud |
Update the `contract_id` to be not-nullable and add required validation. Remove `Statement#active_lead_provider_id` as this is now redundant (we can get the `active_lead_provider` via the `contract`). Change `Statement` uniqeness validation to work through `contract.active_lead_provider`. Update all references in specs.
ethax-ross
force-pushed
the
require-contract-id
branch
from
8efe262 to
3990c6d
Compare
|
leandroalemao
approved these changes
Feb 18, 2026
mooktakim
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We are now migrating contracts and populate the contract on all statements (in both seed data and the data migration), so we want to make
contractmandatory with validation and non-nullable foreign key.As we can reach
ActiveLeadProviderviaStatement#contractwe no longer need to referenceStatement#active_lead-providerdirectly and can remove it.Changes proposed in this pull request
Update the
contract_idto be not-nullable and add required validation.Remove
Statement#active_lead_provider_idas this is now redundant (we can get theactive_lead_providervia thecontract).Change
Statementuniqueness validation to work throughcontract.active_lead_provider.Update all references in specs.
Guidance to review
Now that
Statementdoesn't have a direct association toActiveLeadProviderwe can't enforce uniqueness (of month/year/active lead provider) at the database level. We weren't doing this previously anyway, but it is something we could have done and no longer can without the direct reference in place (there can be multiple contracts for anActiveLeadProvider).