Bring back zones in gui/blueprint (WIP)
#5222
Conversation
|
looks like you might be missing some includes causing the builds to fail. keep up the good work, maybe in some months you'll be cranking out like a c++ pro. |
| a.max_buckets == b.max_buckets && | ||
| a.max_soap == b.max_soap; | ||
| } | ||
|
|
||
| static const char * get_zone_keys(const df::building_civzonest *zone) { |
There was a problem hiding this comment.
This function needs to be rewritten to support the blueprint format for zones and locations. The docs are here: https://docs.dfhack.org/en/latest/docs/guides/quickfort-user-guide.html#zone-mode and here: https://docs.dfhack.org/en/latest/docs/guides/quickfort-user-guide.html#zone-mode-reference
There was a problem hiding this comment.
a good way to test this is to set up zones of each type next to each other, take a blueprint of them, and apply the blueprint with gui/quickfort. Do the quickfort-created zones look the same as the originals?
Also, create zones and add taverns/temples/guildhalls/hospitals. When you blueprint a zone with an attached location, do you successfully create a new location with the same configuration as the original?
Create two meeting zones and attach the same tavern hall to both of them. When you blueprint the pair, does quickfort correctly create two identical zones, with both attached to the same new tavern (which should have the same configuration as the original tavern)?
|
This isn't quite correct, but I have a follow-up PR that will fill in the holes |
ref: #4994