#3256 Added arrival and goal columns to gui/manipulator #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbennitt
commented
Jun 1, 2025
| @@ -1060,7 +1066,7 @@ function Spreadsheet:render(dc) | |||
| local selected = self.namelist:getSelected() | |||
| for _, col in ipairs(self.cols.subviews) do | |||
| col.subviews.col_list.page_top = page_top | |||
| col.subviews.col_list:setSelected(selected) | |||
| col.subviews.col_list.selected = selected | |||
There was a problem hiding this comment.
Calling setSelected resets a bunch of values that we do not want changed because it calls List:moveCursor internally. Just changing the selected value keeps the whole sheet in sync and everything renders correctly using mouse or keyboard navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added columns to gui/manipulator for time since arrival and goal (dreams of...).