[immortal-cravings] prioritize high-value meals #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab9rf
reviewed
Jul 4, 2025
| @@ -13,6 +13,27 @@ function distance(p1, p2) | |||
| return math.max(math.abs(p1.x - p2.x), math.abs(p1.y - p2.y)) + math.abs(p1.z - p2.z) | |||
| end | |||
|
|
|||
| ---find best item in an item vector (according to some metric) | |||
There was a problem hiding this comment.
it seems to me that findClosest is findBest but with a specific metric (distance) and so findClosest could be written as a specialization of findBest
There was a problem hiding this comment.
You are of course right. I realized this at some point and then forgot about it. I just tried it, but the result is barely simpler and less efficient, because one now needs to compute the position (xyz2pos(dfhack.items.getPosition(item))) separately for the metric and the accessibility check. I can do it, but I don't think it is worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and don't go eating or drinking on a full stomach
fixes: DFHack/dfhack#5401