Skip to content

Cleanup & chores #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 6, 2025
Merged

Cleanup & chores #11

merged 32 commits into from
Apr 6, 2025

Conversation

maehr
Copy link
Member

@maehr maehr commented Apr 1, 2025

Pull request

  • Chore: update R and npm dependencies
  • Feat: remove example projects
  • Feat: basic setup information (fix README does not reflect setup #6)
  • Feat: Readme update
  • Feat: codespace settings added

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@flicksolutions flicksolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I couldn't get quarto to run on my windows machine. It's not done by simple installing quarto as it says in the README.
Do you mind updating the readme so I can get it to run, then I can also do a proper code review.

@maehr maehr requested a review from flicksolutions April 2, 2025 11:40
Copy link
Member

@flicksolutions flicksolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor windows comments, but I am approving this, since it's only on windows where we get problems and the canon way of developing the page will be Codespaces? :-)

@maehr maehr merged commit 30ecadd into DHBern:main Apr 6, 2025
5 checks passed
@maehr maehr linked an issue Apr 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README does not reflect setup
2 participants