Skip to content

Conversation

maehr
Copy link
Member

@maehr maehr commented Apr 4, 2025

Pull request

  • feat: add Metadata Handbook with non-discriminatory metadata guidelines

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features
    • Introduced a landing page for the Metadata Handbook, providing an overview, author information, and resource links.
    • Added embedded and downloadable formats (HTML, PDF, Word) for the handbook.
    • Included callouts for PDF access and updates about the upcoming Version 2, highlighting ongoing community-driven development.

@maehr maehr marked this pull request as ready for review May 21, 2025 06:41
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Walkthrough

A new introductory Quarto markdown file for the "Metadata Handbook" project has been added. This file provides project metadata, author information, resource links, and outlines the handbook’s purpose, intended audience, and current development status, including details about the upcoming Version 2 and its collaborative approach.

Changes

File(s) Change Summary
content/projects/metadata-handbook/index.qmd Added a new Quarto markdown file introducing the Metadata Handbook project, including metadata, author details, resource links, project overview, and development updates.

Poem

In the fields where histories grow,
A handbook now begins to show—
With metadata, fair and bright,
Guiding scholars to do it right.
Rabbits cheer this open quest,
For knowledge shared is always best!
🐇📚✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (4)
content/projects/metadata-handbook/index.qmd (4)

1-3: Consider adding a slug for URL consistency
While title and subtitle are defined, including a slug: metadata-handbook in the front‐matter can help ensure a stable permalink and simplify cross-linking within your site.


12-22: Review multiple corresponding: true flags
All three authors are marked corresponding: true. Typically only one corresponding author is designated. Either select a primary contact or clarify the intention behind multiple corresponding entries.


31-50: Validate custom link sections and external link behavior

  • Ensure your theme supports the custom front-matter keys other-links and code-links.
  • If you’d like external links to open in a new tab, you can add Quarto attributes (e.g., .open new) or use windowed: true in the link definitions.

55-61: Use Quarto’s native PDF embed instead of raw <iframe>
Leverage Quarto’s built-in pdf callout for better portability and cleaner markup:

::: {pdf}
-path: handbuch-diskriminierungsfreie-metadaten.pdf
+path: handbuch-diskriminierungsfreie-metadaten.pdf
 height: 600px
 title: "Metadata Handbook"
:::
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 27318af and cdb3ef4.

⛔ Files ignored due to path filters (1)
  • content/projects/metadata-handbook/handbuch-diskriminierungsfreie-metadaten.pdf is excluded by !**/*.pdf
📒 Files selected for processing (1)
  • content/projects/metadata-handbook/index.qmd (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build, Optimize, and Upload Artifacts

Comment on lines +63 to +69
::: {.callout-note title="Work on Version 2 Underway"}
Since its first publication in June 2024, this handbook has been used and discussed by a growing community of researchers, archivists, and data professionals. Based on the extensive feedback received, a second, significantly expanded and reorganized version is currently in development.

Levyn Bürki has joined the author team to support this next phase. Their contributions focus on improving inclusive metadata practices, refining data standards, and updating the handbook’s structure to better support practical use in historical research and cultural heritage institutions.

Version 2 will continue the handbook’s role as an open, living document—publicly available and collaboratively maintained on [GitHub](https://github.com/maehr/diskriminierungsfreie-metadaten)—with the goal of fostering
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix truncated sentence in Version 2 callout
The sentence currently ends with “with the goal of fostering” and is incomplete. Please finish the thought to maintain clarity and coherence.

🤖 Prompt for AI Agents
In content/projects/metadata-handbook/index.qmd around lines 63 to 69, the
callout note about Version 2 ends with an incomplete sentence "with the goal of
fostering." Complete this sentence by adding the intended conclusion to clearly
express the goal, ensuring the thought is fully conveyed and the text reads
smoothly.

Comment on lines +4 to +11
author:
- name: Levyn Bürki
orcid: 0009-0009-7602-0714
email: [email protected]
affiliation: University of Bern
roles:
- writing
corresponding: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Standardize affiliation entries and verify ORCID format
The first author uses a scalar affiliation while the others use lists. For consistency—and to avoid YAML parsing issues—represent all affiliations as lists. Also confirm each ORCID follows the 0000-0000-0000-0000 pattern.

-  affiliation: University of Bern
+  affiliation:
+    - University of Bern
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
author:
- name: Levyn Bürki
orcid: 0009-0009-7602-0714
email: [email protected]
affiliation: University of Bern
roles:
- writing
corresponding: true
author:
- name: Levyn Bürki
orcid: 0009-0009-7602-0714
email: [email protected]
affiliation:
- University of Bern
roles:
- writing
corresponding: true
🤖 Prompt for AI Agents
In content/projects/metadata-handbook/index.qmd around lines 4 to 11, the author
metadata uses a scalar value for the affiliation of the first author, while
others use lists. To fix this, change the affiliation field for all authors to
be lists, even if there is only one affiliation. Additionally, verify that each
ORCID follows the standard 0000-0000-0000-0000 format and correct any
deviations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants