Support for level 2 data #567
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #567 will not alter performanceComparing Summary
|
Cadair
reviewed
Jun 3, 2025
And probably some other benefits down the line
Cadair
reviewed
Jun 10, 2025
Cadair
reviewed
Sep 4, 2025
| aligned_axes = tuple(quantities.aligned_axes[key] for key in quantities.keys()) | ||
| return Inversion( | ||
| node["quantities"], | ||
| meta=node["meta"], |
Member
There was a problem hiding this comment.
We need to handle the node["quantities"].meta part of the tree here, probably by adding it to node["meta"]
SolarDrew
commented
Sep 10, 2025
| "gwcs>=0.24.0", # Inverse transform fix | ||
| "matplotlib>=3.7", | ||
| "ndcube[plotting,reproject]>=2.1", | ||
| "ndcube[plotting,reproject] @ git+https://github.com/sunpy/ndcube@asdf-support", |
Contributor
Author
There was a problem hiding this comment.
Didn't mean to commit this but it does remind me that this PR will have to wait until the corresponding ndcube PR has been merged.
SolarDrew
commented
Sep 10, 2025
| devdeps: matplotlib>=0.0.dev0 | ||
| devdeps: sunpy>=0.0.dev0 | ||
| devdeps: git+https://github.com/sunpy/ndcube | ||
| devdeps: git+https://github.com/sunpy/ndcube@asdf-support |
Contributor
Author
There was a problem hiding this comment.
Again, this can go once the ndcube PR is merged.
Contributor
Author
|
Figure failures are because of using a PR branch of ndcube and should go away once it's merged and we switch back to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can merge this PR:
The NDCube PR requires: