Loft continuity attribute #847
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the attribute loftContinuity to wingType and fuselageType. Currently the default behaviour in TiGL is C0 continuity for wings and C2 continuity for fuselages. If not set, these defaults should be kept, otherwise the value of loftContinuity should be considered when lofting the component in TiGL.
Extracted loftContinuityType for reusability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default lofting logic in TiGL is that fuselages and ducts are lofted with C2 continuity and wings with C0 continuity.
The proposed changes to CPACS add an optional attribute to the wingType, fuselageType and ductType that allows explicitly setting the continuity for the respective component.
If omitted, the defaults of TiGL as described above should be kept. If set, the default behaviour may be overruled.