Add option to configure NGINX real ip #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
approved these changes
May 10, 2025
| @@ -69,5 +69,10 @@ add_header X-Content-Type-Options "nosniff"; | |||
| add_header X-XSS-Protection "1; mode=block"; | |||
| add_header X-Robots-Tag "none" always; | |||
|
|
|||
| {% if NGINX_REAL_IP_FROM is defined %} | |||
There was a problem hiding this comment.
This is the name of the solution, not of the feature.
I propose to call it something like FRONT_REVERSE_PROXY so people know when to set this.
Co-authored-by: Bartjan Henkemans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our setup, we need to configure the proxy for IP autologin.
@vmcj As this is only relevant for domserver, I suggest adding a new
group_varsfile instead of clutteringall. What do you think?