Explicit handle ignoring the return code for failed error messages #3045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gave a compiler warning.
meisterT
reviewed
Aug 4, 2025
| @@ -233,7 +233,9 @@ void verbose(const char *format, ...) | |||
| void verbose_from_signalhandler(const char* msg) | |||
| { | |||
| if (!be_quiet && be_verbose) { | |||
| write(STDERR_FILENO, msg, strlen(msg)); | |||
| if (write(STDERR_FILENO, msg, strlen(msg) != 0)) { | |||
There was a problem hiding this comment.
I think I would prefer just an explicit cast to (void) instead of these if's.
There was a problem hiding this comment.
Casting to void is indeed better (TIL).
But that doesn't work because write has warn_unused_result. So we either have to do this, or wrap it in a custom function. Alternative is using a pragma but that would be even more lines.
Using the custom function would open the risk that we use it more often, and unintentionally not check the result. So I think here my current implementation is the right one (although I was not aware of that before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gave a compiler warning.