Install and apply sane Rector rules #3314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
rector
branch
from
ce6b3f6 to
b3b690b
Compare
Member
|
Why is this better? https://github.com/DOMjudge/domjudge/pull/3314/files#diff-ebb0d9a14289d7ffedd4c5f1df222e3215630edd6e6b96aaeaab21dd6f61bcb3R975 maybe we should add rector as an CI job to detect such cases like we have for PHPCS, otherwise I think we will get both styles inconsistently. |
vmcj
approved these changes
Dec 27, 2025
Member
Author
Way less typing without losing much legibility imho. But if others disagree we can drop this one |
nickygerritsen
force-pushed
the
rector
branch
from
b3b690b to
739e6ce
Compare
eldering
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed some rules we didn't like before, but I think this is a good set of rules to use.
The rector.php file can be used to rerun rector.