Skip to content

Run migrations on PR environments#1440

Draft
bencalegari wants to merge 2 commits intomainfrom
bc/pr-env-fixes
Draft

Run migrations on PR environments#1440
bencalegari wants to merge 2 commits intomainfrom
bc/pr-env-fixes

Conversation

@bencalegari
Copy link
Copy Markdown
Contributor

@bencalegari bencalegari commented Mar 3, 2026

Update bin/update-pr-environment to run migrations on PR environments. Prior to this, the PR env workflow was just building the image and deploying it in Terraform without it.

Changes

  • run-command now takes an optional workspace flag so we can execute migrations and anything else we'd like on different environments.

Acceptance testing

  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

@github-actions github-actions bot requested a review from j-shilling March 3, 2026 02:33
Copy link
Copy Markdown
Contributor

@tdooner tdooner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make it create a separate copy of the database for the review app, too, or else it's going to break Dev when we delete a column (or something like that) in a review app.

@bencalegari bencalegari marked this pull request as draft March 3, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants