Conversation
# Conflicts: # app/next.config.js
…vements (caching training data locallly, removing document orientation rotation)
tdooner
left a comment
tdooner
left a comment
There was a problem hiding this comment.
Looks good and mergeable as-is, all things considered. I might recommend merging this via squashing it into a single commit so that we don't get a much larger git repo from the addition and removal of all those .next and node_modules files.
app/Dockerfile
Outdated
| ARG RUN_UID | ||
| ARG RUN_USER | ||
| ARG RUN_UID=${UID:-4000} | ||
| ARG RUN_USER=${USER:-'nodummy'} |
There was a problem hiding this comment.
I couldn't find any documentation that this syntax is supported here. Does it work?
| "outputs": {}, | ||
| "resources": [], | ||
| "check_results": null | ||
| } |
There was a problem hiding this comment.
This file shouldn't exist since the terraform state is stored in S3, right? We certainly don't want to commit the state here by accident.
| # size = 100, # Size in MiB | ||
| # mountOptions = ["defaults"] | ||
| # } | ||
| # ] |
There was a problem hiding this comment.
In general, we should remove code rather than commenting it out.
node_modules/.bin/tsc
Outdated
There was a problem hiding this comment.
It would be nice to add node_modules and .next to .gitignore so they aren't accidentally included again.
| # will have NAT gateways, which allows the service in the private subnet to | ||
| # make calls to the internet. | ||
| has_external_non_aws_service = false | ||
| has_external_non_aws_service = true |
There was a problem hiding this comment.
This might cost us $30/month per NAT gateway. I will log into AWS to see what they're projecting this thing to cost.
3 participants
Ticket
Changes