Skip to content

Conversation

@chporter
Copy link
Contributor

Modified as per Ayman Suleiman at Jan 2025 DSSAT sprint.
-- ES occurs from top 15 cm only. Re-instate UPFLOW.
-- Uses MESEV = "M" (for Modified Suleiman-Ritchie)

This runs for all DSSAT experiments and treatments. Soil evaporation is considerably lower than all other methods. I ran the default soil evaporation in each FileX vs R, S, and M method override using external simulation control file.

Average ratio over all experiments / treatments
0.98393 | Ritchie : default
1.183594 | Suleiman-Ritchie : default
0.716105 | Modified Suleiman-Ritchie : default
0.62579 | Modified Suleiman-Ritchie : Suleiman-Ritchie

This needs to be thoroughly vetted by Ayman, Gerrit, Fabio, Bruce before accepting the pull request.

chporter added 8 commits February 6, 2025 12:28
- this solves much of the problems with Bambara Groundnut, but there are still some small differences
- CO2EM in Summary.OUT problem fixed.
…nal simulation controls are read

- previously, we had redundant code with separate checks for FileX simulation controls and for external SC
- caused a problem with guar, which was allowed for N fixation in FileX but not external SC.
@chporter chporter closed this Feb 26, 2025
@aymansuleiman
Copy link

aymansuleiman commented Feb 26, 2025 via email

@chporter
Copy link
Contributor Author

chporter commented Mar 3, 2025

@aymansuleiman @GerritHoogenboom
I changed the soil depth to 30 cm and it improved results (i.e., came closer to what we expected), but still only evaporates about 86% on average of Ritchie method and about 72% of the original Suleiman-Ritchie method.
ET_comparison_30.xlsx

@aymansuleiman
Copy link

aymansuleiman commented Mar 3, 2025 via email

chporter added 3 commits March 13, 2025 16:02
- don't export SWDELTU because we also call UPFLOW with this method.
- add some intializations
- make more generic, can easily change depths of soil evaporation by changing one line of code.
- currently using the same A and B coefficients as the original for comparison. Will change these in a separate step after testing.
- not needed or used anywhere
- causes zero divide
- final depth of evaporation = 50 cm
- this can be changed easily by modifying line 60
@chporter chporter reopened this Mar 14, 2025
@chporter
Copy link
Contributor Author

I modified the method with the following:

  • it's now more generic and the depth of evap can be changed with one line of code to simplify exploring the range of options.
  • Modified S-R calls UPFLOW routine to move water up, but also takes water from layers up to specified depth. The evaporation is not (yet) added to UPFLOW which is used to move soil N. We probably want to make this change before finalizing it.
  • I corrected an error where the mulch evaporation was not taken into account prior to calling the routine previously, so these results are slightly different.

The 15cm depth and even going up to 30 cm is not enough to increase evaporation to more than the Ritchie method (on average). I also tried 50 cm and it does increase evaporation slightly (+4% over the Ritchie method).

I also tested the model with a depth of 200 cm which should give similar results to the original Suleiman-Ritchie model. It is very similar, with differences due to the addition of UPFLOW.

The attached plot shows how the various methods compare to the Ritchie method for all the DSSAT experiments and treatments.

The source code currently has the 50 cm depth but we need to discuss this prior to merging the pull request.

image

@aymansuleiman
Copy link

aymansuleiman commented Mar 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants