feat(flinksql): collect comment, type attribute for entity #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cythia828
force-pushed
the
feat/collect_attribute
branch
from
2c3cbd4
to
cb9a37a
Compare
liuxy0551
reviewed
Jul 1, 2024
HaydenOrz
reviewed
Jul 1, 2024
| this.pushEntity(ctx, EntityContextType.DATABASE_CREATE, { | ||
| needCollectAttr: true, | ||
| attrList: [attrName.comment], | ||
| endContext: 'CreateDatabaseContext', |
There was a problem hiding this comment.
可以用 CreateDatabaseContext.constructor.name 代替吗
There was a problem hiding this comment.
不可以哦，在这里CreateDatabaseContext.constructor.name 是Function
There was a problem hiding this comment.
CreateDatabaseContext.name
LuckyFBB
reviewed
Jul 1, 2024
|
@liuxy0551 @HaydenOrz 关于你们的comment，已经提交了新的commit，可以再次review一下 |
HaydenOrz
reviewed
Jul 4, 2024
src/parser/common/entityCollector.ts
Outdated
| return 'line' in value; | ||
| } | ||
|
|
||
| export function isColumnEntityContext(value: EntityContext): value is ColumnEntityContext { |
src/parser/common/entityCollector.ts
Outdated
| return 'params' in value && 'returns' in value && 'relatedEntities' in value; | ||
| } | ||
|
|
||
| export function isWordRange(value: any): value is WordRange { |
There was a problem hiding this comment.
同上，且参数类型应该是 TextSlice | WordRange
| this.pushEntity(ctx, EntityContextType.DATABASE_CREATE, { | ||
| needCollectAttr: true, | ||
| attrList: [attrName.comment], | ||
| endContext: 'CreateDatabaseContext', |
There was a problem hiding this comment.
CreateDatabaseContext.name
|
@HaydenOrz 优化的commit已提交，可再次review |
Cythia828
added a commit
to Cythia828/dt-sql-parser
that referenced
this pull request
Aug 2, 2024
* feat(flinksql): collect comment, type attribute for entity * feat(flinksql): delete console log * fix(DTStack#305): delete function ctxToWord,using ctxToText instead of ctxToWord * feat: update attribute's type * feat(flinksql): update flinksql's entitycollect unit test * feat: optimize interface and update unit test * feat: update collect attr detail * feat: optimize interface and some function's arguments * feat: add comment and update params' name * feat: collect alias in select statement * feat: update collect attribute function and update unit test --------- Co-authored-by: zhaoge <>
HaydenOrz
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat(flinksql): collect comment, type attribute for entity * feat(flinksql): delete console log * fix(#305): delete function ctxToWord,using ctxToText instead of ctxToWord * feat: update attribute's type * feat(flinksql): update flinksql's entitycollect unit test * feat: optimize interface and update unit test * feat: update collect attr detail * feat: optimize interface and some function's arguments * feat: add comment and update params' name * feat: collect alias in select statement * feat: update collect attribute function and update unit test --------- Co-authored-by: zhaoge <>
Cythia828
added a commit
to Cythia828/dt-sql-parser
that referenced
this pull request
Aug 2, 2024
* feat(flinksql): collect comment, type attribute for entity * feat(flinksql): delete console log * fix(DTStack#305): delete function ctxToWord,using ctxToText instead of ctxToWord * feat: update attribute's type * feat(flinksql): update flinksql's entitycollect unit test * feat: optimize interface and update unit test * feat: update collect attr detail * feat: optimize interface and some function's arguments * feat: add comment and update params' name * feat: collect alias in select statement * feat: update collect attribute function and update unit test --------- Co-authored-by: zhaoge <>
HaydenOrz
pushed a commit
to HaydenOrz/dt-sql-parser
that referenced
this pull request
Aug 27, 2024
* feat(flinksql): collect comment, type attribute for entity * feat(flinksql): delete console log * fix(DTStack#305): delete function ctxToWord,using ctxToText instead of ctxToWord * feat: update attribute's type * feat(flinksql): update flinksql's entitycollect unit test * feat: optimize interface and update unit test * feat: update collect attr detail * feat: optimize interface and some function's arguments * feat: add comment and update params' name * feat: collect alias in select statement * feat: update collect attribute function and update unit test --------- Co-authored-by: zhaoge <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Fix
Description
_取属性名，antlr4ng目前解析出来属性名都是带_，是公有的。甚至以type命名前后都有下划线，应该是以防重名，无关私有公有findAttributeChildren方法里的child类型，因为antlr4ng 的ParserRuleContext里，children并未重申类型，导致children类型为ParseTree[]，需要和三方提PR修改isAlias属性和alias、reference、comment几个可选属性，alias为别名，reference为被引用的实体。