feat: collect entity's attribute(comment,alias,colType) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cythia828
changed the title
Cythia828
changed the title
Cythia828
changed the title
added 6 commits
August 2, 2024 14:16
Cythia828
force-pushed
the
feat/collect_attribute
branch
from
4bd17fe
to
c291daf
Compare
Cythia828
changed the title
HaydenOrz
approved these changes
Aug 23, 2024
HaydenOrz
pushed a commit
to HaydenOrz/dt-sql-parser
that referenced
this pull request
Aug 27, 2024
* feat(trinosql): collect trino sql's attribute(comment,alias,colType) * feat(hivesql): collect hive sql's attribute(comment,alias,colType) * feat(impalasql): collect attribute(comment, colType, alias) * feat(sparksql): collect entity's attribute (comment,alias, colType) * feat: update endContextList of collect attribute * feat(postgresql): collect hive sql's attribute(alias,colType) * feat: update interface of attrInfo and alter entitycollect ts file * feat(mysql): collect entity's attribute(comment,colType,alias) * ci: fix check-types problem --------- Co-authored-by: zhaoge <>
HaydenOrz
pushed a commit
that referenced
this pull request
Oct 17, 2024
* feat(trinosql): collect trino sql's attribute(comment,alias,colType) * feat(hivesql): collect hive sql's attribute(comment,alias,colType) * feat(impalasql): collect attribute(comment, colType, alias) * feat(sparksql): collect entity's attribute (comment,alias, colType) * feat: update endContextList of collect attribute * feat(postgresql): collect hive sql's attribute(alias,colType) * feat: update interface of attrInfo and alter entitycollect ts file * feat(mysql): collect entity's attribute(comment,colType,alias) * ci: fix check-types problem --------- Co-authored-by: zhaoge <>
liuxy0551
pushed a commit
to liuxy0551/dt-sql-parser
that referenced
this pull request
Oct 21, 2024
* feat(trinosql): collect trino sql's attribute(comment,alias,colType) * feat(hivesql): collect hive sql's attribute(comment,alias,colType) * feat(impalasql): collect attribute(comment, colType, alias) * feat(sparksql): collect entity's attribute (comment,alias, colType) * feat: update endContextList of collect attribute * feat(postgresql): collect hive sql's attribute(alias,colType) * feat: update interface of attrInfo and alter entitycollect ts file * feat(mysql): collect entity's attribute(comment,colType,alias) * ci: fix check-types problem --------- Co-authored-by: zhaoge <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat
#340
comment,colType,alias属性comment,colType,alias属性comment,colType,alias属性comment,colType,alias属性comment,colType,alias属性comment,colType,alias属性Tips
endContextList，后期都有调整过，原因是我们查找的顺序是从实体所在的位置去查找的，而结束节点是为了让向上查找提前结束，如果设置的节点是与实体同层甚至比实体层级更低的话，那么向上查找会一直找到跟节点，增加无谓的查找，所以调整endContextList里的结束节点，一定是在实体节点的上层的节点pushEntity的第三个参数attrInfo的类型，改为AttrInfo[]，AttrInfo里的attrName为字符串，这样能保证每个属性与其结束节点是对应的，不会因为别的属性的结束节点提交结束查找而错过正确答案