Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix model's value not change and add onEditorInstanceMount event #882

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Dec 26, 2023

Description

  • fix model's value not change when call updateTab
  • support onEditorInstanceMount event handler
  • disable clickable when hide track

Related Issues

close #881
close #880
close #866

@mortalYoung mortalYoung added the bug Something isn't working label Dec 26, 2023
@mortalYoung mortalYoung self-assigned this Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (57804b6) 91.00% compared to head (3fe0e90) 90.94%.

Files Patch % Lines
src/controller/editor.tsx 0.00% 3 Missing ⚠️
src/services/workbench/editorService.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   91.00%   90.94%   -0.06%     
==========================================
  Files         188      188              
  Lines        6080     6085       +5     
  Branches     1478     1476       -2     
==========================================
+ Hits         5533     5534       +1     
- Misses        541      545       +4     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mumiao mumiao self-requested a review December 28, 2023 08:38
@mumiao
Copy link
Collaborator

mumiao commented Dec 29, 2023

测试覆盖率有点问题,看下要不要修复

@mortalYoung
Copy link
Collaborator Author

测试覆盖率有点问题,看下要不要修复

不补啦,editor controller 的覆盖率一直比较低,service 的我加了已经

@mumiao mumiao merged commit f126404 into main Dec 29, 2023
4 of 6 checks passed
@mumiao mumiao deleted the patch/fix branch December 29, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants