cmake: use -flto=auto compiler flag when supported, rework fast-math disablement #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use -flto=auto compiler flag when supported, this silence this GCC warning: > lto-wrapper: warning: using serial compilation of # LTRANS jobs This also greatly speeds-up the linkage time as it enables LTO multithreading in GCC (either by using Make jobserver if detected, either by detecting CPU cores). Also always set LTO if enabled.
Some compilers may enable fast-math by default (example: ICC). Some contractions are still safe and can be enabled.
illwieckz
force-pushed
the
illwieckz/cmake
branch
from
166155c to
867022a
Compare
illwieckz
changed the title
illwieckz
force-pushed
the
illwieckz/cmake
branch
from
867022a to
160640b
Compare
illwieckz
changed the title
illwieckz
force-pushed
the
illwieckz/cmake
branch
from
867022a to
629da09
Compare
illwieckz
force-pushed
the
illwieckz/cmake
branch
3 times, most recently
from
2abc19b to
27c13ac
Compare
slipher
reviewed
Mar 19, 2025
There was a problem hiding this comment.
Any numbers on performance impact of the strict math flags? Reproducible floating-point operations are of somewhat niche interest and have limited chance to be reliably achieved between differing compilers and architectures, so I think that would be a bad default if it costs more than a few percent of speed.
| @@ -88,12 +98,8 @@ if (MSVC) | |||
| endif() | |||
|
|
|||
| if (USE_LTO) | |||
| set_cxx_flag("/GL" RELEASE) | |||
| set_cxx_flag("/GL" RELWITHDEBINFO) | |||
There was a problem hiding this comment.
The point of these is to have different flags per configuration in a multi-configuration build, so that you can test a Release build with LTO and a Debug build without it from the same IDE instance.
It's OK to remove this for the GCC-style options since it gets in the way of flag tests, but there is no need to remove it for MSVC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake: use -flto=auto compiler flag when supported
Use -flto=auto compiler flag when supported, this silence this
GCC warning:
This also greatly speeds-up the linkage time as it enables LTO
multithreading in GCC (either by using Make jobserver if detected,
either by detecting CPU cores).
Also always set LTO if enabled.
Similar to:
cmake: rework the fast-math enablement and force the disablement
Some compilers may enable fast-math by default (example: ICC).
Some contractions are still safe and can be enabled.
cmake: fix typo