Fixes #133: Fix search index display_attrs referencing non-existent fields #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent fields SupportContractAssignmentIndex and LicenseAssignmentIndex had display_attrs that referenced fields from their parent models instead of their own fields. This caused a FieldDoesNotExist error when searching for devices with support contract assignments. Changes: - SupportContractAssignmentIndex: use contract, sku, device instead of vendor, start, renewal - LicenseAssignmentIndex: use license, vendor, device instead of manufacturer - Add regression tests for display_attrs validation
jsenecal
force-pushed
the
fix/issue-133-search-display-attrs
branch
from
3e07673 to
f1fd3d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
test_search.py