Closes #85 - Extend support contract assignments to modules #91
Conversation
|
Hello ! @DanSheps or any of the allowed reviewers, is there any chance to have the awaiting PRs reviewed soon ? Just asking to anticipate. Thanks, and have a good day! |
| if self.device and self.license and SupportContractAssignment.objects.filter( | ||
| if self.module: | ||
| if self.license or self.device: | ||
| raise ValidationError('Assigning a Module excludes the assigment of a Device or License') |
There was a problem hiding this comment.
I don't know if I agree with this. I think selecting a device or license (or both) would be valid depending on the circumstances.
A module is always going to be in a device, and when removing from a device in NetBox it is deleted.
I think a more reasonable check would be to ensure that this is unique across all 3 fields.
In addition, you would want to add unique checks for:
device, module where license is None
module, license where device is None (or just require a device when saving a module)
| if self.cleaned_data.get('module'): | ||
| if self.cleaned_data.get('license') or self.cleaned_data.get('device'): | ||
| raise forms.ValidationError({ | ||
| 'module': 'Selecting a Module excludes the selection of a Device or License' | ||
| }) | ||
|
|
There was a problem hiding this comment.
See comment in the model and adjust accordingly
2 participants
Closes #85 to extend the Support Contract Assignment feature to Modules.
Please note that, as License Assignments are available only for Devices, I've made the assumption that if a Module is selected/assigned in a Support Contract Assignment, neither a Device nor a License Assignment can be selected/assigned to the same one.
Let me know if you agree with that assumption, I can update if you don't.