Mashrafe #39

MashrafeJess · 2025-11-19T10:55:25Z

Email verification and token

Some endpoints return 204 but still the CRUD works

Copilot

Pull Request Overview

This pull request implements email verification, password reset, and token management functionality for the authentication server. However, the PR contains numerous issues including spelling errors, incorrect error messages, security vulnerabilities, and configuration problems that need to be addressed.

Key Changes

Added new domain entities and endpoints for Token, EmailVerification, and PasswordReset management with full CRUD operations
Added Application entity and endpoints for OAuth application management
Updated database context and configurations to support new entities
Added validation rules for the new commands

Reviewed Changes

Copilot reviewed 89 out of 95 changed files in this pull request and generated 32 comments.

Show a summary per file

File	Description
src/Domain/Token/Tokens.cs	Defines the Token domain entity with properties for OAuth tokens
src/Domain/EmailVerification/EmailVerifications.cs	Defines the EmailVerification entity for tracking email verification tokens
src/Domain/PasswordResets/PasswordReset.cs	Defines the PasswordReset entity for password reset token management
src/Domain/Application/Applications.cs	Defines the Applications entity for OAuth application management
src/Domain/Enums/Status.cs	Adds Status enum for application status tracking
src/Infrastructure/Token/TokenConfiguration.cs	Entity Framework configuration for Tokens (contains bugs)
src/Infrastructure/Token/IentityTypeConfiguration.cs	Custom configuration base class (should not exist)
src/Infrastructure/PasswordResets/PasswordResetConfiguration.cs	Entity Framework configuration for PasswordReset
src/Infrastructure/EmailVerfication/EmailVerficationsConfiguration.cs	Entity Framework configuration for EmailVerifications
src/Infrastructure/Application/ApplicationConfiguration.cs	Entity Framework configuration for Applications (contains duplicate property config)
src/Infrastructure/Database/ApplicationDbContext.cs	Updates DbContext with new DbSets for added entities
src/Application/Token/Create/*	Command, handler, and validator for creating tokens
src/Application/Token/Update/*	Command and handler for updating tokens
src/Application/Token/Get/*	Query and handler for retrieving token lists
src/Application/Token/GetById/*	Query and handler for retrieving single token
src/Application/Token/Delete/*	Command, handler, and validator for deleting tokens
src/Application/EmailVerification/Create/*	Command, handler, and validator for creating email verifications
src/Application/EmailVerification/Update/*	Command and handler for updating email verifications
src/Application/EmailVerification/Get/*	Query and handler for retrieving email verification lists
src/Application/EmailVerification/GetById/*	Query and handler for retrieving single email verification
src/Application/EmailVerification/Delete/*	Command, handler, and validator for deleting email verifications
src/Application/PasswordResets/Create/*	Command, handler, and validator for creating password resets
src/Application/PasswordResets/Update/*	Command and handler for updating password resets
src/Application/PasswordResets/Get/*	Query and handler for retrieving password reset lists (contains bugs)
src/Application/PasswordResets/GetById/*	Query and handler for retrieving single password reset
src/Application/PasswordResets/Delete/*	Command, handler, and validator for deleting password resets
src/Application/Application/Create/*	Command, handler, and validator for creating applications
src/Application/Abstractions/Data/IApplicationDbContext.cs	Updates interface with new DbSet properties
src/Web.Api/Endpoints/Token/*	REST endpoints for Token CRUD operations
src/Web.Api/Endpoints/EmailVerification/*	REST endpoints for EmailVerification CRUD operations
src/Web.Api/Endpoints/PasswordResets/*	REST endpoints for PasswordReset CRUD operations
src/Web.Api/Endpoints/Application/Create.cs	REST endpoint for creating applications
src/Web.Api/Endpoints/Tags.cs	Adds API tags for new endpoint groups
src/Web.Api/Program.cs	Adds developer exception page and debug logging (security issues)
src/Web.Api/appsettings.Development.json	Updates database connection password
src/SharedKernel/ErrorType.cs	Adds Unexpected error type enum value
src/SharedKernel/Result.cs	Formatting change with extraneous whitespace
AuthServer.sln	Updates Visual Studio version (invalid version number)
.gitignore	Ignores AuthServer.sln file (questionable practice)

Files not reviewed (2)

src/Infrastructure/Database/Migrations/20240811190111_Create_Database.Designer.cs: Language not supported
src/Infrastructure/Database/Migrations/20251109165202_create_customer.Designer.cs: Language not supported

src/Application/EmailVerification/Create/CreateEmailVerificationCommandValidator.cs

src/Application/EmailVerification/Delete/DeleteEmailVerificationCommandValidator.cs

src/SharedKernel/Result.cs

src/Infrastructure/Token/TokenConfiguration.cs

src/Domain/PasswordResets/PasswordResetErrors.cs

src/Application/Token/Create/CreateTokenCommand.cs

src/Web.Api/Endpoints/Token/Create.cs

src/Application/PasswordResets/GetById/GetPasswordResetByIdQueryHandler.cs

src/Application/PasswordResets/Get/GetPasswordResetQueryHandler.cs

src/Web.Api/Program.cs

…onCommandValidator.cs Co-authored-by: Copilot <[email protected]>

…r.cs Co-authored-by: Copilot <[email protected]>

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

…ndValidator.cs Co-authored-by: Copilot <[email protected]>

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 88 out of 93 changed files in this pull request and generated 14 comments.

Files not reviewed (2)

src/Infrastructure/Database/Migrations/20240811190111_Create_Database.Designer.cs: Language not supported
src/Infrastructure/Database/Migrations/20251109165202_create_customer.Designer.cs: Language not supported

src/Web.Api/Program.cs

src/Application/PasswordResets/Get/GetPasswordResetQueryHandler.cs

src/Application/Token/Update/UpdateTokenCommandHandler.cs

src/Application/Token/GetById/GetTokenByIdQueryHandler.cs

src/Application/PasswordResets/Delete/DeletePasswordResetCommandHandler.cs

src/Web.Api/Endpoints/EmailVerification/GetById.cs

src/Web.Api/Endpoints/PasswordResets/GetById.cs

src/Web.Api/Endpoints/Token/GetById.cs

src/Infrastructure/Token/TokenConfiguration.cs

src/Infrastructure/PasswordResets/PasswordResetConfiguration.cs

…r.cs Co-authored-by: Copilot <[email protected]>

…ndHandler.cs Co-authored-by: Copilot <[email protected]>

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 91 out of 96 changed files in this pull request and generated 17 comments.

Files not reviewed (2)

src/Infrastructure/Database/Migrations/20240811190111_Create_Database.Designer.cs: Language not supported
src/Infrastructure/Database/Migrations/20251109165202_create_customer.Designer.cs: Language not supported

src/Infrastructure/EmailVerification/EmailVerficationsConfiguration.cs

src/Domain/EmailVerification/EmailVerificationCreatedDomainEvent.cs

src/Infrastructure/Database/ApplicationDbContext.cs

src/Domain/Token/Tokens.cs

src/Domain/PasswordResets/PasswordReset.cs

src/Web.Api/appsettings.Development.json

src/Application/PasswordResets/Create/CreatePasswordResetCommandValidator.cs

src/Application/Properties/launchSettings.json

src/Domain/PasswordResets/PasswordResetErrors.cs

Copilot

Pull Request Overview

Copilot reviewed 91 out of 96 changed files in this pull request and generated 37 comments.

Files not reviewed (2)

src/Infrastructure/Database/Migrations/20240811190111_Create_Database.Designer.cs: Language not supported
src/Infrastructure/Database/Migrations/20251109165202_create_customer.Designer.cs: Language not supported

src/Application/Application/Create/CreateApplicationValidator.cs

src/Domain/PasswordResets/PasswordReset.cs

src/Domain/EmailVerification/EmailVerificationCreatedDomainEvent.cs

src/Application/Application/Create/CreateApplicationCommandHandler.cs

src/Application/EmailVerification/Create/CreateEmailVerificationCommandValidator.cs

src/Application/Token/Get/TokenResponse.cs

src/Application/Token/Get/GetTokensQueryHandler.cs

src/Domain/EmailVerification/EmailVerifications.cs

src/Application/Application/Create/CreateApplicationValidator.cs

Copilot

Pull Request Overview

Copilot reviewed 87 out of 92 changed files in this pull request and generated 11 comments.

Files not reviewed (2)

src/Infrastructure/Database/Migrations/20240811190111_Create_Database.Designer.cs: Language not supported
src/Infrastructure/Database/Migrations/20251109165202_create_customer.Designer.cs: Language not supported

src/Web.Api/Program.cs

src/Infrastructure/Token/TokenConfiguration.cs

src/Infrastructure/PasswordResets/PasswordResetConfiguration.cs

src/Infrastructure/EmailVerification/EmailVerficationsConfiguration.cs

src/Infrastructure/Application/ApplicationConfiguration.cs

src/Application/Application/Create/CreateApplicationValidator.cs

src/Application/Application/Create/CreateApplicationCommandHandler.cs

src/Domain/Token/Tokens.cs

src/Domain/PasswordResets/PasswordReset.cs

src/Domain/EmailVerification/EmailVerifications.cs

…onCommandValidator.cs Co-authored-by: Copilot <[email protected]>

…into mashrafe

…o mashrafe

MashrafeJess added 6 commits November 16, 2025 23:18

Configuration Done

abdb841

update DB

848e960

Final

4a794d3

Without Migration Folder

cbdd96f

Initial commit on new branch

55ba698

Merge branch 'recover-pr' into mashrafe

2dccfbc

MashrafeJess requested a review from mihaduldev November 19, 2025 10:55

MashrafeJess assigned dapplesoft Nov 19, 2025

MashrafeJess added the bug Something isn't working label Nov 19, 2025

MashrafeJess linked an issue Nov 19, 2025 that may be closed by this pull request

Adding Email Verification, Password Reset and Token Table #40

Closed

recover

7bdf898

mihaduldev requested review from Copilot and removed request for mihaduldev November 19, 2025 14:53

mihaduldev assigned MashrafeJess Nov 19, 2025

Copilot started reviewing on behalf of mihaduldev November 19, 2025 14:54 View session

Copilot finished reviewing on behalf of mihaduldev November 19, 2025 14:59

Copilot AI reviewed Nov 19, 2025

View reviewed changes

MashrafeJess and others added 8 commits November 20, 2025 09:57

Update src/Application/EmailVerification/Create/CreateEmailVerificati…

c9a7de6

…onCommandValidator.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/EmailVerification/Delete/DeleteEmailVerificati…

2e0968d

…onCommandValidator.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/PasswordResets/Get/GetPasswordResetQueryHandle…

2783ecd

…r.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/EmailVerification/Update/UpdateEmailVerificati…

7a83e75

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/PasswordResets/Create/CreatePasswordResetComma…

e029c32

…ndValidator.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/EmailVerification/Create/CreateEmailVerificati…

92d3bfe

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/Application/Create/CreateApplicationCommand.cs

482565e

Co-authored-by: Copilot <[email protected]>

Resolve merge + restore local changes

cc674bf

mihaduldev requested a review from Copilot November 20, 2025 04:56

Copilot started reviewing on behalf of mihaduldev November 20, 2025 04:56 View session

Copilot finished reviewing on behalf of mihaduldev November 20, 2025 04:57

Copilot AI reviewed Nov 20, 2025

View reviewed changes

Update src/Application/PasswordResets/Get/GetPasswordResetQueryHandle…

7f267f5

…r.cs Co-authored-by: Copilot <[email protected]>

MashrafeJess and others added 3 commits November 20, 2025 11:03

Update src/Application/PasswordResets/Delete/DeletePasswordResetComma…

0885a52

…ndHandler.cs Co-authored-by: Copilot <[email protected]>

Update src/Application/EmailVerification/Create/CreateEmailVerificati…

c2918a4

…onCommandHandler.cs Co-authored-by: Copilot <[email protected]>

2nd Resolve Done

133f8fc

mihaduldev requested a review from Copilot November 20, 2025 05:34

Copilot started reviewing on behalf of mihaduldev November 20, 2025 05:35 View session

Copilot finished reviewing on behalf of mihaduldev November 20, 2025 05:36

Copilot AI reviewed Nov 20, 2025

View reviewed changes

mihaduldev requested a review from Copilot November 20, 2025 05:48

Copilot started reviewing on behalf of mihaduldev November 20, 2025 05:48 View session

Copilot finished reviewing on behalf of mihaduldev November 20, 2025 05:53

Copilot AI reviewed Nov 20, 2025

View reviewed changes

Resolve merge + restore local changes

a409b55

mihaduldev requested a review from Copilot November 20, 2025 06:53

Copilot started reviewing on behalf of mihaduldev November 20, 2025 06:53 View session

Copilot finished reviewing on behalf of mihaduldev November 20, 2025 06:55

Copilot AI reviewed Nov 20, 2025

View reviewed changes

MashrafeJess and others added 5 commits November 20, 2025 22:29

3rd

5d28313

Resolve merge + restore local changes

1049735

Update src/Application/EmailVerification/Create/CreateEmailVerificati…

83a7ad9

…onCommandValidator.cs Co-authored-by: Copilot <[email protected]>

4th Review

b588e97

Merge branch 'mashrafe' of https://github.com/Dapplesoft-AD/AuthServer …

6915bf5

…into mashrafe

MashrafeJess unassigned dapplesoft Nov 20, 2025

MashrafeJess added 4 commits November 24, 2025 00:57

Resolve Conflict

728d276

5th

afccf5a

6

575b2a1

Merge branch 'Dev' of https://github.com/Dapplesoft-AD/AuthServer int…

ab06a0a

…o mashrafe

MashrafeJess merged commit 0ae7575 into Dev Nov 24, 2025

MashrafeJess mentioned this pull request Nov 24, 2025

Revert "Mashrafe" #54

Closed

Mashrafe #39

Mashrafe #39

Uh oh!

Conversation

MashrafeJess commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees