Moon Phase Cycle config - #1465
Open
dwinters99 wants to merge 7 commits into
Open
Conversation
| @@ -1,8 +1,23 @@ | |||
| /// Current phase of the moon, randomly chosen | |||
| GLOBAL_VAR_INIT(moon_state, get_moon_phase()) | |||
Member
There was a problem hiding this comment.
This has a race condition, config gets loaded AFTER var init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Moon phase is now decided by server config.
Options are:
Why It's Good For The Game
We've had several complaints about how long a particular moon phase lasts and I talked with @Iamgoofball about it in the discord a while back so I decided it'd be best to leave it to the servers.
Changelog
🆑
config: Added 3 options for the Lunar Cycle
/:cl: