Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 60-sysprobe-check.sh is too chatty in Docker agent image #15187

Open
artyom opened this issue Jan 20, 2023 · 1 comment · May be fixed by #15188
Open

[BUG] 60-sysprobe-check.sh is too chatty in Docker agent image #15187

artyom opened this issue Jan 20, 2023 · 1 comment · May be fixed by #15188
Labels
team/containers

Comments

@artyom
Copy link

artyom commented Jan 20, 2023

Agent Environment

Agent version 7.41.1, pulled in from public.ecr.aws/datadog/agent:7 image:

$ docker run -it --rm public.ecr.aws/datadog/agent:7 /bin/bash
Unable to find image 'public.ecr.aws/datadog/agent:7' locally
7: Pulling from datadog/agent
6f935188a310: Already exists 
Digest: sha256:4992b38387ca6dbb732f3493ed66cdf5efe7e08154b7e9e4159b1735dbaabe3f
Status: Downloaded newer image for public.ecr.aws/datadog/agent:7
root@7173535d3eed:/# agent version
Agent 7.41.1 - Commit: 4f39b9e - Serialization version: v5.0.39 - Go version: go1.18.9
root@7173535d3eed:/# cat /etc/datadog-agent/system-probe.yaml
cat: /etc/datadog-agent/system-probe.yaml: No such file or directory

Describe what happened:

When agent container is configured via environment variables, without explicit configuration files provided, on container launch it will emit this line:

grep: /etc/datadog-agent/system-probe.yaml: No such file or directory

This originates from 60-sysprobe-check.sh script:

datadog-agent/Dockerfiles/agent/cont-init.d/60-sysprobe-check.sh

Line 3 in 360d2b2

if grep -Eq '^ *enable_tcp_queue_length *: *true' /etc/datadog-agent/system-probe.yaml || [[ "$DD_SYSTEM_PROBE_CONFIG_ENABLE_TCP_QUEUE_LENGTH" == "true" ]]; then

Describe what you expected:

No unnecessary output.

Steps to reproduce the issue:

Launch agent container with some valid configuration, but don't provide it with any explicit configuration files.

Additional environment details (Operating System, Cloud provider, etc):

Observed in AWS Fargate.
artyom added a commit to artyom/datadog-agent that referenced this issue Jan 20, 2023
@artyom
Mute 60-sysprobe-check.sh in the absence of config
5e47ef0 
Closes DataDog#15187
@artyom artyom linked a pull request Jan 20, 2023 that will close this issue
Open
10 tasks
artyom added a commit to artyom/datadog-agent that referenced this issue Feb 13, 2023
@artyom
Mute 60-sysprobe-check.sh in the absence of config
3b425f3 
Closes DataDog#15187
@seanorama
Copy link

Still observed in 7.50.x. In my case, on Kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mute 60-sysprobe-check.sh in the absence of config artyom/datadog-agent
3 participants
@artyom @vickenty @seanorama