Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute 60-sysprobe-check.sh in the absence of config #15188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artyom
Copy link

@artyom artyom commented Jan 20, 2023

Closes #15187

What does this PR do?

Mutes grep: /etc/datadog-agent/system-probe.yaml: No such file or directory message coming from 60-sysprobe-check.sh in the Docker image, where such file is not present.

Motivation

See #15187

Additional Notes

Alternative solution is to build custom docker image and maintain this fix separately.

Possible Drawbacks / Trade-offs

N/a

Describe how to test/QA your changes

N/a

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@artyom artyom requested a review from a team as a code owner January 20, 2023 12:00
@bits-bot
Copy link
Collaborator

bits-bot commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !
Thanks for your submission !

Indeed, the system-probe.yaml configuration file isn’t mandatory anymore.
Rather than completely hiding all errors, I left a suggestion to leverage an option of grep to silent only errors about nonexistent files.

@artyom
Copy link
Author

artyom commented Feb 13, 2023

@L3n41c thank you for your suggestion! Indeed, -s option fits much nicer — please see the updated change.

@L3n41c
Copy link
Member

L3n41c commented Feb 13, 2023

@artyom : The CircleCI seems to fail because of an authentication issue. See this link.
Could you try to sign out of CircleCI and then to log back on GitHub and then on CircleCI as suggested to see if it fixes it.

@artyom
Copy link
Author

artyom commented Feb 13, 2023

@L3n41c I don't have a CircleCI account. Should I create one to unblock the pipeline?

@L3n41c
Copy link
Member

L3n41c commented Feb 13, 2023

@artyom I think you may need to sign up with your GitHub account. I’m not 100% sure.

@artyom
Copy link
Author

artyom commented Feb 13, 2023

@L3n41c ok, I signed up to CircleCI with my GitHub account, please see if that helped. I cannot re-run the workflow myself.

@st-cyrill
Copy link

@L3n41c
I faced the same problem. I hope this pull request will be merge.
Can you help us take the next action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 60-sysprobe-check.sh is too chatty in Docker agent image
4 participants