-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute 60-sysprobe-check.sh in the absence of config #15188
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for your submission !
Indeed, the system-probe.yaml
configuration file isn’t mandatory anymore.
Rather than completely hiding all errors, I left a suggestion to leverage an option of grep
to silent only errors about nonexistent files.
@L3n41c thank you for your suggestion! Indeed, -s option fits much nicer — please see the updated change. |
@L3n41c I don't have a CircleCI account. Should I create one to unblock the pipeline? |
@artyom I think you may need to sign up with your GitHub account. I’m not 100% sure. |
@L3n41c ok, I signed up to CircleCI with my GitHub account, please see if that helped. I cannot re-run the workflow myself. |
@L3n41c |
Closes #15187
What does this PR do?
Mutes
grep: /etc/datadog-agent/system-probe.yaml: No such file or directory
message coming from60-sysprobe-check.sh
in the Docker image, where such file is not present.Motivation
See #15187
Additional Notes
Alternative solution is to build custom docker image and maintain this fix separately.
Possible Drawbacks / Trade-offs
N/a
Describe how to test/QA your changes
N/a
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.