Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in Mac agent install script #14317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goodspark
Copy link

Fixes #14316

I also went ahead and changed all the single-character equality checks with double, since this script is meant to be run as a Bash script and the usage was inconsistent throughout the file.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@goodspark goodspark requested a review from a team as a code owner November 15, 2022 05:01
@bits-bot
Copy link
Collaborator

bits-bot commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@mx-psi
Copy link
Member

mx-psi commented Nov 28, 2022

Thanks for the PR @goodspark! In order to accept it you need to sign the CLA by visiting https://cla.datadoghq.com/DataDog/datadog-agent?pullRequest=14317 and following the instructions there

@jrdemasi
Copy link

@mx-psi Since the bot indicated all committers signed the CLA can this get merged?

@KevinFairise2
Copy link
Member

Hi
Thanks for the PR @goodspark, could you please rebase your PR on main branch so we can run all the tests before merging this?

@goodspark
Copy link
Author

@KevinFairise2 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MacOS agent install script fails
6 participants