Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix permission check on $SECURITY_AGENT_CONFIG_FILE #17157

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sietse
Copy link

@sietse sietse commented May 16, 2023

$SECURITY_AGENT_CONFIG_FILE does not need to be executable, merely readable.

This fixes spurious error /etc/datadog-agent/security-agent.yaml not found. Exiting datadog-agent-security, caused by the startupscript wrongly checking for an executable config file instead of a readable one.

TODO:

  • check other (non-Debian) service files for faulty check logic
  • go down PR checklist / read Contributing.md

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

$SECURITY_AGENT_CONFIG_FILE does not need to be executable, merely readable.
@sietse sietse requested a review from a team as a code owner May 16, 2023 13:14
@bits-bot
Copy link
Collaborator

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sietse sietse marked this pull request as draft May 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants