Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(parser): describe the received data #19184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nilleb
Copy link

@nilleb nilleb commented Sep 3, 2023

What does this PR do?

In order to better understand which is the source of the error, print the received configuration on the output.

Motivation

Receiving an error message like

WARN | (pkg/logs/schedulers/ad/scheduler.go:74 in Schedule) | Invalid configuration: could not parse JSON logs config: json: cannot unmarshal string into Go struct field LogsConfig.Tags of type []string

Does not help diagnose the source of the problem.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

in order to better understand which is the source of the error, print the received configuration on the output
@nilleb nilleb requested a review from a team as a code owner September 3, 2023 15:40
@bits-bot
Copy link
Collaborator

bits-bot commented Sep 3, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants