Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics when using serverless-init #19447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terlenbach
Copy link

What does this PR do?

With the start time of the flush set to start + 10s, we trick the time sampler, and make it believe that the current bucket is closed, making it reporting wrong metrics.

This PR fixes #19446

Motivation

Fixing the issue #19446

Additional Notes

This PR also removed a comment stating the reason for these extra 10 seconds.
It says: "We add 10 seconds to the interval to ensure that we're getting the whole sketches bucket".
My gut feeling is that this reason is no longer valid, but I couldn't find in the git log the bug that this fixed, so I couldn't dig deeper.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

With the start time of the flush set to start + 10s,
we trick the time sampler, and make it believe that the
current bucket is closed, making it reporting wrong metrics.
@terlenbach terlenbach requested a review from a team as a code owner September 13, 2023 15:56
@bits-bot
Copy link
Collaborator

bits-bot commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Metrics values are wrong when using serverless-init
2 participants