Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused remote config for apm tracing #30920

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ajgajg1134
Copy link
Contributor

@ajgajg1134 ajgajg1134 commented Nov 8, 2024

What does this PR do?

Remove code for listening to apm tracing RC Product.

Motivation

This was originally the intended approach to handle RC of single step instrumentation, but has been replaced with fleet automation policies. This code was only used in a proof of concept and there should be no users of this file.

Describe how to test/QA your changes

existing tests are sufficient here.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/remote-config medium review PR review might take time labels Nov 8, 2024
@ajgajg1134 ajgajg1134 added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Nov 8, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 8, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48737644 --os-family=ubuntu

Note: This applies to commit 0a41148

@ajgajg1134 ajgajg1134 marked this pull request as ready for review November 8, 2024 19:36
@ajgajg1134 ajgajg1134 requested review from a team as code owners November 8, 2024 19:36
Copy link

cit-pr-commenter bot commented Nov 8, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1437cebb-dc12-4f00-86a8-5ac56bb69b00

Baseline: 958c609
Comparison: 0a41148
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.59 [+1.66, +9.52] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.59 [+1.66, +9.52] 1 Logs
pycheck_lots_of_tags % cpu utilization +2.25 [-1.22, +5.72] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.22 [+0.49, +1.95] 1 Logs
file_tree memory utilization +0.47 [+0.37, +0.57] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.21 [+0.15, +0.27] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.16 [-0.33, +0.64] 1 Logs
otel_to_otel_logs ingress throughput +0.12 [-0.56, +0.81] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.22, +0.27] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.46, +0.51] 1 Logs
quality_gate_idle_all_features memory utilization +0.00 [-0.11, +0.12] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.32, +0.31] 1 Logs
quality_gate_idle memory utilization -0.02 [-0.08, +0.05] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput -0.12 [-0.31, +0.07] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 1/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 8/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/remote-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants