fix trace writer test race condition (APMSP-1527)

[ajgajg1134]

What does this PR do?

Fix a flaky test from a race condition. This test should be locking the writer while it modifies an internal field.

Motivation

The only flakes I like are corn flakes

Describe how to test/QA your changes

Covered by the test itself

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48696679 --os-family=ubuntu

Note: This applies to commit c78b578

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9392e812-aeae-47c8-bb01-fc5e3dec6af3

Baseline: e07fb1b
Comparison: c78b578
Diff

Optimization Goals: ❌ Significant changes detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	basic_py_check	% cpu utilization	-5.18	[-8.81, -1.55]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	pycheck_lots_of_tags	% cpu utilization	+3.04	[-0.34, +6.43]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.45	[-0.24, +1.14]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.12	[-0.60, +0.84]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.08	[-0.12, +0.27]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.27, +0.37]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.49, +0.54]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.22, +0.25]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.11, +0.06]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.10	[-0.58, +0.38]	1	Logs
➖	file_tree	memory utilization	-0.28	[-0.41, -0.15]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.46	[-0.56, -0.35]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.55	[-0.60, -0.50]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.46	[-1.60, -1.33]	1	Logs
✅	basic_py_check	% cpu utilization	-5.18	[-8.81, -1.55]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_100ms_latency	lost_bytes	5/10
❌	quality_gate_idle	memory_usage	7/10	bounds checks dashboard
❌	file_to_blackhole_0ms_latency	lost_bytes	8/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[ajgajg1134]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-11 16:07:15 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.