Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): Use a non-private channel #33583

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 30, 2025

What does this PR do?

Switch the channel for agent-e2e-framework review

Motivation

The current channel is private, so the review message can't be sent.

Describe how you validated your changes

n/a

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested review from a team as code owners January 30, 2025 14:12
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 30, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 30, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 734013ee47af02b9e71bdf20a38931fe76d280dd

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 899.85MB 899.84MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 909.56MB 909.56MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.84MB 477.84MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.83MB 93.83MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.90MB 93.90MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.90MB 93.90MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.88MB 89.88MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.95MB 89.95MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 922.37MB 922.37MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 922.37MB 922.37MB 0.50MB
datadog-agent-amd64-deb -0.00MB 912.63MB 912.63MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 54450388 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 685c8817-62fa-44aa-9bd9-e3dad2c5ac73

Baseline: 734013e
Comparison: 317d909
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.96 [+0.16, +1.76] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.16 [-0.61, +0.93] 1 Logs
quality_gate_idle memory utilization +0.15 [+0.12, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.93, +0.95] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.28, +0.29] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.76, +0.72] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.99, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.08 [-1.04, +0.89] 1 Logs
file_tree memory utilization -0.14 [-0.21, -0.07] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.26 [-0.73, +0.20] 1 Logs
quality_gate_idle_all_features memory utilization -0.45 [-0.51, -0.38] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.67 [-1.61, +0.26] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.75 [-0.82, -0.69] 1 Logs
quality_gate_logs % cpu utilization -2.07 [-5.09, +0.95] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Member Author

chouetz commented Jan 31, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 31, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-31 07:53:45 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2025-01-31 08:18:51 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b6b1c51 into main Jan 31, 2025
237 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/slack_team_review branch January 31, 2025 08:18
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants