Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to deva #33587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate CI to deva #33587

wants to merge 1 commit into from

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 30, 2025

What does this PR do?

  • Remove use of requirements files in favor of centralized dependency management in deva
  • Adds a custom composite action for easily installing the proper version of deva in GitHub Actions workflows

Motivation

Continuation of DataDog/datadog-agent-buildimages#741

Describe how you validated your changes

  • Ran rg -. "requirements.+txt"
  • Ran rg -. "inv "
  • Removed associated logic in favor of deva usage

@ofek ofek requested a review from a team as a code owner January 30, 2025 16:09
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 30, 2025
@ofek ofek force-pushed the ofek/requirements branch 2 times, most recently from 7d9d6bd to e6cbe38 Compare January 30, 2025 16:54
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 45ceeac7fa1a182b4d25abaf01fcaccba27e9a48

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-amd64-deb 0.00MB 928.91MB 928.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.88MB 477.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 925.81MB 925.81MB 0.50MB
datadog-agent-arm64-deb -0.00MB 916.09MB 916.09MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 54476820 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 13d3936d-15c2-4088-a288-824665f2c9fc

Baseline: 45ceeac
Comparison: e6cbe38
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.72 [+0.82, +2.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.35 [-0.45, +1.14] 1 Logs
quality_gate_idle memory utilization +0.30 [+0.27, +0.34] 1 Logs bounds checks dashboard
file_tree memory utilization +0.22 [+0.16, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.86, +0.95] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.76, +0.79] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.27, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.93, +0.83] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.52, +0.42] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.89, +0.76] 1 Logs
quality_gate_logs % cpu utilization -0.07 [-3.12, +2.97] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.32 [-0.42, -0.23] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.35 [-1.13, +0.44] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.41, -0.31] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@ofek ofek added qa/no-code-change No code change in Agent code requiring validation do-not-merge/WIP labels Jan 30, 2025
@ofek ofek force-pushed the ofek/requirements branch from e6cbe38 to ed554f2 Compare January 31, 2025 06:44
@ofek ofek requested review from a team as code owners January 31, 2025 06:44
@ofek ofek requested review from a team as code owners January 31, 2025 06:44
@ofek ofek requested review from songy23, louis-cqrl and AyyLam January 31, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog do-not-merge/WIP qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-developer-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant