Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasan.mahmood/cilium lb e2e #34398

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

hmahmood
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@hmahmood hmahmood added this to the 7.65.0 milestone Feb 25, 2025
@hmahmood hmahmood added changelog/no-changelog team/networks qa/done QA done before merge and regressions are covered by tests labels Feb 25, 2025
@github-actions github-actions bot added the medium review PR review might take time label Feb 25, 2025
Copy link

Go Package Import Differences

Baseline: 93a1c0c
Comparison: d98560c

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
agentlinuxarm64
+1, -0
+github.com/samber/lo/mutable
agentwindowsamd64
+1, -0
+github.com/samber/lo/mutable
agentdarwinamd64
+1, -0
+github.com/samber/lo/mutable
agentdarwinarm64
+1, -0
+github.com/samber/lo/mutable
iot-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
iot-agentlinuxarm64
+1, -0
+github.com/samber/lo/mutable
heroku-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
cluster-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
cluster-agentlinuxarm64
+1, -0
+github.com/samber/lo/mutable
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/samber/lo/mutable
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/samber/lo/mutable
dogstatsdlinuxamd64
+1, -0
+github.com/samber/lo/mutable
dogstatsdlinuxarm64
+1, -0
+github.com/samber/lo/mutable
process-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
process-agentlinuxarm64
+1, -0
+github.com/samber/lo/mutable
process-agentwindowsamd64
+1, -0
+github.com/samber/lo/mutable
process-agentdarwinamd64
+1, -0
+github.com/samber/lo/mutable
process-agentdarwinarm64
+1, -0
+github.com/samber/lo/mutable
heroku-process-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
security-agentlinuxamd64
+1, -0
+github.com/samber/lo/mutable
security-agentlinuxarm64
+1, -0
+github.com/samber/lo/mutable
security-agentwindowsamd64
+1, -0
+github.com/samber/lo/mutable
system-probelinuxamd64
+1, -0
+github.com/samber/lo/mutable
system-probelinuxarm64
+1, -0
+github.com/samber/lo/mutable
system-probewindowsamd64
+1, -0
+github.com/samber/lo/mutable

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 56834052 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1db204e3-6935-4fc2-806c-723b572077c5

Baseline: 93a1c0c
Comparison: d98560c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.93 [+1.05, +2.81] 1 Logs
quality_gate_logs % cpu utilization +0.66 [-2.23, +3.55] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.60, +0.72] 1 Logs
quality_gate_idle memory utilization +0.44 [+0.39, +0.49] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.69, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.79, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.79, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.80, +0.80] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.70, +0.69] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.30, +0.28] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.82, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization -0.07 [-0.12, -0.03] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.69, +0.24] 1 Logs
file_tree memory utilization -0.24 [-0.30, -0.19] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant