GPU: added hostgpu inventory payload #34429
Draft
+460
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added mocks added placeholders for actual collectors
val06
added
changelog/no-changelog
team/ebpf-platform
qa/done
val06
changed the title
Go Package Import DifferencesBaseline: 565c054
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=56907888 --os-family=ubuntuNote: This applies to commit 228c220 |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 565c054 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +0.85 | [-2.06, +3.76] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.46 | [+0.42, +0.50] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.30 | [-0.16, +0.75] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.27 | [-0.59, +1.13] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.19 | [-0.58, +0.95] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.73, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.03 | [-0.60, +0.66] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.83, +0.88] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.77, +0.79] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.67, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.00 | [-0.83, +0.82] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.31, +0.28] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.04 | [-0.10, +0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.46 | [-0.53, -0.40] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.84 | [-0.90, -0.78] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
hush-hush
requested changes
Feb 26, 2025
| @@ -325,6 +325,12 @@ Package haagent implements a component to generate the 'ha_agent_metadata' metad | |||
|
|
|||
| Package host implements a component to generate the 'host' metadata payload (also known as "v5"). | |||
|
|
|||
| ### [comp/metadata/hostgpu](https://pkg.go.dev/github.com/DataDog/datadog-agent/comp/metadata/hostgpu) | |||
There was a problem hiding this comment.
Will there be a non host GPU at some point ? Or could we rename this compmetadata/gpu ?
| @@ -0,0 +1,78 @@ | |||
| # Inventory Host Payload | |||
|
|
|||
| This package populates some of the Agent-related fields in the `inventories` product in DataDog. More specifically the | |||
There was a problem hiding this comment.
Suggested change
| This package populates some of the Agent-related fields in the `inventories` product in DataDog. More specifically the | |
| This package populates some of the Agent-related fields in the `Resource Catalog` product in DataDog. More specifically the |
| # Inventory Host Payload | ||
|
|
||
| This package populates some of the Agent-related fields in the `inventories` product in DataDog. More specifically the | ||
| `host_gpu_agent` table. |
There was a problem hiding this comment.
Suggested change
| `host_gpu_agent` table. | |
| `host_gpu` table. |
Comment on lines
+11
to
+14
| # Content | ||
|
|
||
| The `Set` method from the component allows the rest of the codebase to add any information to the payload. | ||
|
|
There was a problem hiding this comment.
There is no Set method for this comp:
Suggested change
| # Content | |
| The `Set` method from the component allows the rest of the codebase to add any information to the payload. |
| @@ -0,0 +1,13 @@ | |||
| // Unless explicitly stated otherwise all files in this repository are licensed | |||
There was a problem hiding this comment.
Do we need a mock for this comp ? It doesn't seems to be used by anything directly.
If we need it, please move the mock to comp/metadata/hostgpu/mock (ie: this section).
| // Component is the component type. | ||
| type Component interface { | ||
| // Refresh trigger a new payload to be sent while still respecting the minimal interval between two updates. | ||
| Refresh() |
Comment on lines
+87
to
+88
| // Dependencies defines the dependencies for the hostgpu component | ||
| type Dependencies struct { |
There was a problem hiding this comment.
Cf the doc please rename this Requires.
| } | ||
|
|
||
| func (gh *gpuHost) getPayload() marshaler.JSONMarshaler { | ||
| gh.fillData() |
There was a problem hiding this comment.
Will this ever changed within the life-cycle of the Agent ? If not we could compute it only once (maybe at initialization ?).
Comment on lines
+86
to
+94
| p := NewGPUHostProvider( | ||
| fxutil.Test[Dependencies]( | ||
| t, | ||
| fx.Provide(func() log.Component { return logmock.New(t) }), | ||
| fx.Provide(func() workloadmeta.Component { return &wmsMock{} }), | ||
| config.MockModule(), | ||
| fx.Provide(func() serializer.MetricSerializer { return serializermock.NewMetricSerializer(t) }), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
We want impl folders to not require FX, this allows non-FX project like OTEL to use those implementation (more on this here)
Suggested change
| p := NewGPUHostProvider( | |
| fxutil.Test[Dependencies]( | |
| t, | |
| fx.Provide(func() log.Component { return logmock.New(t) }), | |
| fx.Provide(func() workloadmeta.Component { return &wmsMock{} }), | |
| config.MockModule(), | |
| fx.Provide(func() serializer.MetricSerializer { return serializermock.NewMetricSerializer(t) }), | |
| ), | |
| ) | |
| p := NewGPUHostProvider(Requires{ | |
| WMeta: &wmsMock{}, | |
| Log: logmock.New(t), | |
| Config: configmock.New(t), | |
| Serializer: serializermock.NewMetricSerializer(t), | |
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new payload to collect gpu devices information from the host.
Currently only nvidia devices are supported.
Motivation
Collect host's system information related to GPUs
Describe how you validated your changes
UTs added
Possible Drawbacks / Trade-offs
Additional Notes
Using Workload Meta Store (WMS) as the source to get the list of nvidia gpu devices.