Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade module with version v0.0.0-00010101000000-000000000000 #35417

Merged
merged 6 commits into from
Mar 28, 2025

Conversation

ogaca-dd
Copy link
Contributor

What does this PR do?

Upgrade module with version v0.0.0-00010101000000-000000000000

Motivation

Describe how you validated your changes

Run unit tests.

Possible Drawbacks / Trade-offs

Additional Notes

@ogaca-dd ogaca-dd added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Mar 24, 2025
@github-actions github-actions bot added the medium review PR review might take time label Mar 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 24, 2025

Uncompressed package size comparison

Comparison with ancestor b8d329a55038dbb7960e94e479f776045213bdc1

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 807.12MB 807.12MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 816.96MB 816.96MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 816.96MB 816.96MB 0.50MB
datadog-agent-arm64-deb 0.00MB 798.08MB 798.08MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 807.91MB 807.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.58MB 39.58MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.58MB 39.58MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 38.02MB 38.02MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 442.27MB 442.27MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.12MB 61.12MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.19MB 61.19MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.19MB 61.19MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 58.40MB 58.40MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 58.48MB 58.48MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 24, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 781.4 MiB 781.68 MiB 190.72 MiB 191.21 MiB
static_quality_gate_agent_deb_amd64_fips 779.37 MiB 779.64 MiB 190.06 MiB 190.66 MiB
static_quality_gate_agent_rpm_amd64 781.35 MiB 781.68 MiB 193.13 MiB 193.7 MiB
static_quality_gate_agent_rpm_amd64_fips 779.37 MiB 779.78 MiB 192.52 MiB 193.02 MiB
static_quality_gate_agent_rpm_arm64 772.69 MiB 773.19 MiB 174.19 MiB 174.7 MiB
static_quality_gate_agent_rpm_arm64_fips 770.92 MiB 771.33 MiB 173.4 MiB 173.92 MiB
static_quality_gate_agent_suse_amd64 781.4 MiB 781.76 MiB 193.13 MiB 193.7 MiB
static_quality_gate_agent_suse_arm64 772.74 MiB 773.22 MiB 174.19 MiB 174.7 MiB
static_quality_gate_agent_suse_amd64_fips 779.34 MiB 779.77 MiB 192.52 MiB 193.02 MiB
static_quality_gate_agent_suse_arm64_fips 770.91 MiB 771.34 MiB 173.4 MiB 173.92 MiB
static_quality_gate_agent_msi 977.35 MiB 980.98 MiB 149.64 MiB 150.11 MiB
static_quality_gate_agent_heroku_amd64 429.8 MiB 430.25 MiB 112.58 MiB 113.11 MiB
static_quality_gate_dogstatsd_deb_amd64 37.75 MiB 38.23 MiB 9.78 MiB 10.28 MiB
static_quality_gate_dogstatsd_deb_arm64 36.34 MiB 36.82 MiB 8.49 MiB 8.98 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.75 MiB 38.23 MiB 9.79 MiB 10.29 MiB
static_quality_gate_dogstatsd_suse_amd64 37.75 MiB 38.23 MiB 9.79 MiB 10.29 MiB
static_quality_gate_iot_agent_deb_amd64 58.36 MiB 58.84 MiB 14.75 MiB 15.24 MiB
static_quality_gate_iot_agent_deb_arm64 55.78 MiB 56.26 MiB 12.74 MiB 13.23 MiB
static_quality_gate_iot_agent_deb_armhf 54.45 MiB 54.93 MiB 12.73 MiB 13.23 MiB
static_quality_gate_iot_agent_rpm_amd64 58.36 MiB 58.84 MiB 14.77 MiB 15.26 MiB
static_quality_gate_iot_agent_rpm_arm64 55.78 MiB 56.26 MiB 12.76 MiB 13.25 MiB
static_quality_gate_iot_agent_suse_amd64 58.36 MiB 58.84 MiB 14.77 MiB 15.26 MiB
static_quality_gate_docker_agent_amd64 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_arm64 880.57 MiB 881.08 MiB 277.76 MiB 278.3 MiB
static_quality_gate_docker_agent_jmx_amd64 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_jmx_arm64 880.57 MiB 881.08 MiB 277.76 MiB 278.3 MiB
static_quality_gate_docker_agent_windows1809 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_core 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_core_jmx 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_jmx 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_core 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_core_jmx 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_jmx 865.93 MiB 866.39 MiB 291.3 MiB 291.84 MiB
static_quality_gate_docker_dogstatsd_amd64 45.89 MiB 46.37 MiB 17.3 MiB 17.8 MiB
static_quality_gate_docker_dogstatsd_arm64 44.51 MiB 44.99 MiB 16.17 MiB 16.66 MiB
static_quality_gate_docker_cluster_agent_amd64 262.94 MiB 263.29 MiB 105.59 MiB 106.03 MiB
static_quality_gate_docker_cluster_agent_arm64 278.9 MiB 279.25 MiB 100.45 MiB 100.87 MiB
static_quality_gate_docker_cws_instrumentation_amd64 6.65 MiB 7.15 MiB 2.82 MiB 3.32 MiB
static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.94 MiB 2.6 MiB 3.1 MiB

Copy link

cit-pr-commenter bot commented Mar 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9884406f-a003-4648-b575-03de6041ac40

Baseline: b8d329a
Comparison: 04946ae
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.89 [+0.03, +5.76] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.42 [+0.56, +2.29] 1 Logs
otlp_ingest_metrics memory utilization +1.19 [+1.05, +1.33] 1 Logs
quality_gate_idle memory utilization +0.55 [+0.46, +0.63] 1 Logs bounds checks dashboard
otlp_ingest_traces memory utilization +0.43 [+0.04, +0.82] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.38, +0.56] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.74, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.75, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.82, +0.83] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.28, +0.28] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.79, +0.79] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.74, +0.74] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
file_tree memory utilization -0.21 [-0.34, -0.08] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.24 [-0.27, -0.20] 1 Logs
quality_gate_idle_all_features memory utilization -0.39 [-0.49, -0.28] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.57 [-0.74, -0.41] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.67 [-1.42, +0.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.36 [-1.43, -1.29] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@ogaca-dd ogaca-dd marked this pull request as ready for review March 24, 2025 20:56
@ogaca-dd ogaca-dd requested review from songy23, L3n41c and arbll March 25, 2025 13:40
@ogaca-dd
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2025

View all feedbacks in Devflow UI.
2025-03-25 19:14:08 UTC ℹ️ Start processing command /merge


2025-03-25 19:14:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-25 23:15:03 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 25, 2025

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_iot_agent_rpm_armhf 54.44 MiB 54.93 MiB 15.4 MiB 13.24 MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_iot_agent_rpm_armhf AssertionError Package size on wire (compressed package size) 16145196 is higher than the maximum allowed 13883146 by the gate !

Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 781.27 MiB 781.68 MiB 190.73 MiB 191.21 MiB
static_quality_gate_agent_deb_amd64_fips 779.21 MiB 779.64 MiB 190.06 MiB 190.66 MiB
static_quality_gate_agent_rpm_amd64 781.31 MiB 781.68 MiB 193.18 MiB 193.7 MiB
static_quality_gate_agent_rpm_amd64_fips 779.31 MiB 779.78 MiB 192.56 MiB 193.02 MiB
static_quality_gate_agent_rpm_arm64 772.8 MiB 773.19 MiB 174.3 MiB 174.7 MiB
static_quality_gate_agent_rpm_arm64_fips 771.01 MiB 771.33 MiB 173.42 MiB 173.92 MiB
static_quality_gate_agent_suse_amd64 781.42 MiB 781.76 MiB 193.18 MiB 193.7 MiB
static_quality_gate_agent_suse_arm64 772.79 MiB 773.22 MiB 174.3 MiB 174.7 MiB
static_quality_gate_agent_suse_amd64_fips 779.36 MiB 779.77 MiB 192.56 MiB 193.02 MiB
static_quality_gate_agent_suse_arm64_fips 770.98 MiB 771.34 MiB 173.42 MiB 173.92 MiB
static_quality_gate_agent_msi 980.3 MiB 980.51 MiB 149.61 MiB 150.11 MiB
static_quality_gate_agent_heroku_amd64 429.71 MiB 430.25 MiB 112.61 MiB 113.11 MiB
static_quality_gate_dogstatsd_deb_amd64 37.74 MiB 38.23 MiB 9.78 MiB 10.28 MiB
static_quality_gate_dogstatsd_deb_arm64 36.33 MiB 36.82 MiB 8.48 MiB 8.98 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.74 MiB 38.23 MiB 9.79 MiB 10.29 MiB
static_quality_gate_dogstatsd_suse_amd64 37.74 MiB 38.23 MiB 9.79 MiB 10.29 MiB
static_quality_gate_iot_agent_deb_amd64 58.35 MiB 58.84 MiB 14.74 MiB 15.24 MiB
static_quality_gate_iot_agent_deb_arm64 55.77 MiB 56.26 MiB 12.73 MiB 13.23 MiB
static_quality_gate_iot_agent_deb_armhf 54.44 MiB 54.93 MiB 12.73 MiB 13.23 MiB
static_quality_gate_iot_agent_rpm_amd64 58.35 MiB 58.84 MiB 14.76 MiB 15.26 MiB
static_quality_gate_iot_agent_rpm_arm64 55.77 MiB 56.26 MiB 12.75 MiB 13.25 MiB
static_quality_gate_iot_agent_suse_amd64 58.35 MiB 58.84 MiB 14.76 MiB 15.26 MiB
static_quality_gate_docker_agent_amd64 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_arm64 880.69 MiB 881.08 MiB 277.85 MiB 278.3 MiB
static_quality_gate_docker_agent_jmx_amd64 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_jmx_arm64 880.69 MiB 881.08 MiB 277.85 MiB 278.3 MiB
static_quality_gate_docker_agent_windows1809 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_core 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_core_jmx 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows1809_jmx 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_core 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_core_jmx 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_agent_windows2022_jmx 866.0 MiB 866.39 MiB 291.38 MiB 291.84 MiB
static_quality_gate_docker_dogstatsd_amd64 45.88 MiB 46.37 MiB 17.3 MiB 17.8 MiB
static_quality_gate_docker_dogstatsd_arm64 44.5 MiB 44.99 MiB 16.17 MiB 16.66 MiB
static_quality_gate_docker_cluster_agent_amd64 262.91 MiB 263.29 MiB 105.58 MiB 106.03 MiB
static_quality_gate_docker_cluster_agent_arm64 278.88 MiB 279.25 MiB 100.42 MiB 100.87 MiB
static_quality_gate_docker_cws_instrumentation_amd64 6.65 MiB 7.15 MiB 2.82 MiB 3.32 MiB
static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.94 MiB 2.6 MiB 3.1 MiB

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Mar 28, 2025
@ogaca-dd
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 28, 2025

View all feedbacks in Devflow UI.
2025-03-28 21:48:23 UTC ℹ️ Start processing command /merge


2025-03-28 21:48:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 43m (p90).


2025-03-28 22:23:43 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f376a75 into main Mar 28, 2025
493 checks passed
@dd-mergequeue dd-mergequeue bot deleted the olivierg/remove-v0.0.0-00010101000000 branch March 28, 2025 22:23
@github-actions github-actions bot added this to the 7.66.0 milestone Mar 28, 2025
github-actions bot pushed a commit to jozef-javorsky-dodo/datadog-agent that referenced this pull request Mar 29, 2025
github-actions bot pushed a commit to chanhyeokseo/datadog-agent that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants