Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make failure policy configurable #9088

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikebryant
Copy link
Contributor

What does this PR do?

Make the admission controller failure policy configurable

Motivation

Keep having the datadog agents fail to mutate things during disruption

Fixes #8475

Additional Notes

Starting looking at adding a test, got stuck due to:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestGenerateTemplatesV1$

package github.com/DataDog/datadog-agent/pkg/clusteragent/admission/controllers/webhook: build constraints exclude all Go files in /Users/mikebryant/go/src/github.com/DataDog/datadog-agent/pkg/clusteragent/admission/controllers/webhook

Describe how to test your changes

Not done yet. Providing a work in progress in the hope someone else can help finish this

Write here in detail how you have tested your changes
and instructions on how this should be tested in QA.

Describe or link instructions to set up environment
for testing, if the process requires more than just
running the agent on one of the supported platforms.

Checklist

  • A release note has been added or the changelog/no-changelog label has been applied.
  • The need-change/operator and need-change/helm labels has been applied if applicable.
  • The appropriate team/.. label has been applied, if known.
  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The config template has been updated if applicable.

Note: Adding GitHub labels is only possible for contributors with write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make failurePolicy configurable
1 participant