-
Notifications
You must be signed in to change notification settings - Fork 47
Support P1 components with Observability Pipelines API #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support P1 components with Observability Pipelines API #2523
Conversation
"rule": "rule", | ||
} | ||
|
||
def __init__(self_, rule: str, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, rule: str, **kwargs): | |
def __init__(self, rule: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"use_recommended_keywords": "use_recommended_keywords", | ||
} | ||
|
||
def __init__(self_, id: str, use_recommended_keywords: Union[bool, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, id: str, use_recommended_keywords: Union[bool, UnsetType] = unset, **kwargs): | |
def __init__(self, id: str, use_recommended_keywords: Union[bool, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"type": "type", | ||
} | ||
|
||
def __init__(self_, id: str, type: ObservabilityPipelineSumoLogicSourceType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, id: str, type: ObservabilityPipelineSumoLogicSourceType, **kwargs): | |
def __init__(self, id: str, type: ObservabilityPipelineSumoLogicSourceType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
17eebd3
to
5a3874c
Compare
5a3874c
to
6b26a85
Compare
"proximity": "proximity", | ||
} | ||
|
||
def __init__(self_, keywords: List[str], proximity: int, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, keywords: List[str], proximity: int, **kwargs): | |
def __init__(self, keywords: List[str], proximity: int, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
See DataDog/datadog-api-spec#3786
Test branch datadog-api-spec/test/vladimir-dd/opa-3140