Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datadog::SLOs::SLO] Add retry to read call #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Datadog::SLOs::SLO] Add retry to read call #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4efadfc
add retry to read call
skarimo Nov 10, 2023
af4c356
lint
skarimo Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions datadog-slos-slo-handler/src/datadog_slos_slo/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
from time import sleep
from typing import Any, List, MutableMapping, Optional

from cloudformation_cli_python_lib import (
Expand Down Expand Up @@ -27,6 +28,8 @@
LOG = logging.getLogger(__name__)
TYPE_NAME = "Datadog::SLOs::SLO"
TELEMETRY_TYPE_NAME = "slos-slo"
MAX_RETRY_COUNT = 5
RETRY_SLEEP_INTERVAL = 5

resource = Resource(TYPE_NAME, ResourceModel, TypeConfigurationModel)
test_entrypoint = resource.test_entrypoint
Expand Down Expand Up @@ -59,16 +62,32 @@ def read_handler(
message="Error getting SLO: SLO does not exist",
errorCode=HandlerErrorCode.NotFound,
)
try:
slo = api_instance.get_slo(slo_id)
except ApiException as e:
LOG.error("Exception when calling SLOApi->get_slo: %s\n", e)

retry_count = 0
slo = api_exception = None
while retry_count < MAX_RETRY_COUNT:
retry_count += 1
try:
slo = api_instance.get_slo(slo_id)
api_exception = None
break
except ApiException as e:
api_exception = e
if e.status == 404:
sleep(RETRY_SLEEP_INTERVAL)
continue
else:
break

if api_exception is not None:
LOG.error("Exception when calling SLOApi->get_slo: %s\n", api_exception)
return ProgressEvent(
status=OperationStatus.FAILED,
resourceModel=model,
message=f"Error getting SLO: {e}",
errorCode=http_to_handler_error_code(e.status),
message=f"Error getting SLO: {api_exception}",
errorCode=http_to_handler_error_code(api_exception.status),
)

model.Created = slo.data.created_at
model.Modified = slo.data.modified_at
model.Description = slo.data.description
Expand Down