aws integration cf resource to use new v2 api #317
Conversation
github-actions
bot
added
resource/aws
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
datadog-integrations-aws-handler/src/datadog_integrations_aws/handlers.py
Outdated
Show resolved
Hide resolved
| if desired_metrics_config.NamespaceFilters.IncludeOnly is not None: | ||
| new_namespace_filters = AWSNamespaceFiltersIncludeOnly( | ||
| include_only=desired_metrics_config.NamespaceFilters.IncludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if xray_services_desired_config.IncludeOnly is not None: | ||
| new_xray_services = XRayServicesIncludeOnly(xray_services_desired_config.IncludeOnly) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if desired_metrics_config.NamespaceFilters.ExcludeOnly is not None: | ||
| new_namespace_filters = AWSNamespaceFiltersExcludeOnly( | ||
| exclude_only=desired_metrics_config.NamespaceFilters.ExcludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
jvanbrie
changed the title
| @@ -1 +1 @@ | |||
| git+https://github.com/datadog/datadog-cloudformation-resources.git@datadog-cloudformation-common-python-0.0.17#egg=datadog_cloudformation_common&subdirectory=datadog-cloudformation-common-python | |||
| git+https://github.com/datadog/datadog-cloudformation-resources.git@0b54e768b81bf33e75e774b14fb938698b7add27#egg=datadog_cloudformation_common&subdirectory=datadog-cloudformation-common-python | |||
There was a problem hiding this comment.
This is referencing a particular commit. This will be changed to reference a release before it goes out. I can't reference the release as it's not out yet.
There was a problem hiding this comment.
updated after merging api version bump #316
| if xray_services_desired_config.IncludeOnly is not None: | ||
| new_xray_services = XRayServicesIncludeOnly( | ||
| xray_services_desired_config.IncludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if xray_services_desired_config.IncludeOnly is not None: | ||
| new_xray_services = XRayServicesIncludeOnly( | ||
| xray_services_desired_config.IncludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if desired_metrics_config.NamespaceFilters.IncludeOnly is not None: | ||
| new_namespace_filters = AWSNamespaceFiltersIncludeOnly( | ||
| include_only=desired_metrics_config.NamespaceFilters.IncludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if desired_metrics_config.NamespaceFilters.ExcludeOnly is not None: | ||
| new_namespace_filters = AWSNamespaceFiltersExcludeOnly( | ||
| exclude_only=desired_metrics_config.NamespaceFilters.ExcludeOnly | ||
| ) |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
…int-resource-use-v2
What does this PR do?
Our new v2 api has been released for managing the Datadog AWS Integration. We want to use it in place of our old v1 api everywhere the v1 is currently used. This pr replaces our v1 endpoint with the v2 for the aws-integration cloudformation resource.
Note for reviewers:
There are a lot of generated files. The main files changed are handlers.py, and datadog-integrations-aws.json. Mostly everything else is generated.
Since I made a new resource type for this change, the diff between the handlers isn't visible. If you view the commits up through
8c910faeada02660b8f1ff31914057c65f38ebcc, you can see the diff more clearly.Verification Process
Uploaded and ran the new custom cloudformation resource. Confirmed Create, Update, and Delete work as expected.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.